App crashes if google play store is not installed about react-native-in-app-review HOT 16 CLOSED

@MinaSamir11 Since this error is at the Java level then the JS try-catch block won't help too much, I tested it and the app was still crashing.

I did a lazy patch on my own fork, it's just some try-catch blocks, I left some TODO notes on it for a more elegant solution in the future though.
felipecespedes@249ecfc

from react-native-in-app-review.

When calling the InAppReview.RequestInAppReview() method then the app is crashing if the Google Play Store is not installed.

Google play store is a required dependency as listed in the In-App Review official documentation

Android devices (phones and tablets) running Android 5.0 (API level 21) or higher that have the Google Play Store installed.

Platform: Android

Thank you @felipecespedes , I solve bug without try{}catch{}, now we check if play store installed or not and show in app review if play store exist in user device, install new update and check it out..

from react-native-in-app-review.

@MinaSamir11 when can you update this package for fixing this issue ?

@fevzican update live now, install new package.

from react-native-in-app-review.

If you need, quick sol. You can call method, wrapping it in try {}catch. You will silence error.

So i will work on it to fix crashing app, If user not install dependence.

from react-native-in-app-review.

@MinaSamir11 when can you update this package for fixing this issue ?

from react-native-in-app-review.

@felipecespedes @fevzican i apologize for the pervious version of 2.1.3, i found that is not solved yet. i update package to 2.1.4 for your issue. please notify me if it works or not !
Thank you.

from react-native-in-app-review.

@MinaSamir11 i have tested V2.1.4 and the problem still exist. Also if the Play Store app was disabled the app will crash too

from react-native-in-app-review.

What Android version/API were you testing on? @mToutounjy

from react-native-in-app-review.

@felipecespedes Android 8.1.0 API 26

from react-native-in-app-review.

@felipecespedes Is problem solved for you after update to 2.1.4!! Or still exist!?

from react-native-in-app-review.

@MinaSamir11 i have tested V2.1.4 and the problem still exist. Also if the Play Store app was disabled the app will crash too

If disable, it may crash too. We can resolve it, in next release.
But If playstore is not installed, crash with you too!!

from react-native-in-app-review.

@MinaSamir11 i have tested V2.1.4 and the problem still exist. Also if the Play Store app was disabled the app will crash too

But If playstore is not installed, crash with you too!!

yes

I/ReactNativeJS: RequestInAppReview
I/PlayCore: UID: [10082] PID: [27654] ReviewService : requestInAppReview (xxx.xxx.xxx)
I/PlayCore: UID: [10082] PID: [27654] ReviewService : Initiate binding to the service.
I/PlayCore: UID: [10082] PID: [27654] ReviewService : Failed to bind to the service.
E/isPlayStoreInstalled: true
D/AndroidRuntime: Shutting down VM
E/AndroidRuntime: FATAL EXCEPTION: main
Process: xxx.xxx.xxx, PID: 27654
com.google.android.play.core.tasks.RuntimeExecutionException: com.google.android.play.core.internal.aq: Failed to bind to the service.
at com.google.android.play.core.tasks.m.getResult(Unknown Source:16)
at com.ibits.react_native_in_app_review.AppReviewModule.lambda$show$1$AppReviewModule(AppReviewModule.java:53)
at com.ibits.react_native_in_app_review.-$$Lambda$AppReviewModule$bUmS5pB5E-8STvn0S-VVfLR6ozE.onComplete(Unknown Source:4)
at com.google.android.play.core.tasks.a.run(Unknown Source:23)
at android.os.Handler.handleCallback(Handler.java:790)
at android.os.Handler.dispatchMessage(Handler.java:99)
at android.os.Looper.loop(Looper.java:164)
at android.app.ActivityThread.main(ActivityThread.java:6494)
at java.lang.reflect.Method.invoke(Native Method)
at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:438)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:807)
Caused by: com.google.android.play.core.internal.aq: Failed to bind to the service.
at com.google.android.play.core.internal.ap.a(Unknown Source:78)
at com.google.android.play.core.internal.ai.a(Unknown Source:4)
at com.google.android.play.core.internal.ag.run(Unknown Source:0)
at android.os.Handler.handleCallback(Handler.java:790)
at android.os.Handler.dispatchMessage(Handler.java:99)
at android.os.Looper.loop(Looper.java:164)
at android.os.HandlerThread.run(HandlerThread.java:65)
Process 27654 terminated.

from react-native-in-app-review.

@mToutounjy I hope new release will solve your issue .
please check it out version 2.1.5. and give me feedback again.

from react-native-in-app-review.

Update this bug solved on @2.1.7

@MinaSamir11 i have tested V2.1.4 and the problem still exist. Also if the Play Store app was disabled the app will crash too

But If playstore is not installed, crash with you too!!

yes

I/ReactNativeJS: RequestInAppReview
I/PlayCore: UID: [10082] PID: [27654] ReviewService : requestInAppReview (xxx.xxx.xxx)
I/PlayCore: UID: [10082] PID: [27654] ReviewService : Initiate binding to the service.
I/PlayCore: UID: [10082] PID: [27654] ReviewService : Failed to bind to the service.
E/isPlayStoreInstalled: true
D/AndroidRuntime: Shutting down VM
E/AndroidRuntime: FATAL EXCEPTION: main
Process: xxx.xxx.xxx, PID: 27654
com.google.android.play.core.tasks.RuntimeExecutionException: com.google.android.play.core.internal.aq: Failed to bind to the service.
at com.google.android.play.core.tasks.m.getResult(Unknown Source:16)
at com.ibits.react_native_in_app_review.AppReviewModule.lambda$show$1$AppReviewModule(AppReviewModule.java:53)
at com.ibits.react_native_in_app_review.-$$Lambda$AppReviewModule$bUmS5pB5E-8STvn0S-VVfLR6ozE.onComplete(Unknown Source:4)
at com.google.android.play.core.tasks.a.run(Unknown Source:23)
at android.os.Handler.handleCallback(Handler.java:790)
at android.os.Handler.dispatchMessage(Handler.java:99)
at android.os.Looper.loop(Looper.java:164)
at android.app.ActivityThread.main(ActivityThread.java:6494)
at java.lang.reflect.Method.invoke(Native Method)
at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:438)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:807)
Caused by: com.google.android.play.core.internal.aq: Failed to bind to the service.
at com.google.android.play.core.internal.ap.a(Unknown Source:78)
at com.google.android.play.core.internal.ai.a(Unknown Source:4)
at com.google.android.play.core.internal.ag.run(Unknown Source:0)
at android.os.Handler.handleCallback(Handler.java:790)
at android.os.Handler.dispatchMessage(Handler.java:99)
at android.os.Looper.loop(Looper.java:164)
at android.os.HandlerThread.run(HandlerThread.java:65)
Process 27654 terminated.

from react-native-in-app-review.

any solution for this?

from react-native-in-app-review.

i update the latest version and using emulator without play store, there is an error.
is same if i disable the play store.
but is okay because apps not crash.

from react-native-in-app-review.