Comments (3)
merope07
commented on August 15, 2024
Ok, I see from recent commits there's an effort to standardize on tabbing, so I'll do that.
However, I still think using None for "ok" is bad style, because it inverts the expected meaning of and and or compared to Result.
from grin.
ignopeverell
commented on August 15, 2024
Sorry for mixed tabbing, was likely caused to mixing configurations on my end.
I've been on the fence about Option and I seem to be on the wrong side of that fence as to what's more or less standard in most Rust libraries. So let's revert to Result<(), Error>.
from grin.
merope07
commented on August 15, 2024
Thank you!
from grin.
Related Issues (20)
- [Testnet v5.2.0-alpha.1] Node Stopped working HOT 2
- Grin nodes often get stuck HOT 9
- build website deposit and withdraw grin token using grin-wallet api
- v5.1.2 building error HOT 1
- Potential P2P Bandwidth attack
- log4rs: No space left on device (os error 28) HOT 1
- Config parsing error causes panic
- Very often node is PongMessage instead of HeadersMessage.
- TxHashsetDownload is starting in parallel with TxHashsetPibd HOT 4
- Prune Node sync more than 7 hours HOT 4
- Beta 5.2 Shutdown in step 4/7, many connected_peers: failed to get peers lock, Shutting down reader connection, waiting for thread exit, Shutdown
- bug in computing proof size rounded up to next higher 2-power
- grin 5.1.2 failed to build against rust 1.71.0 HOT 3
- Aborting PIBD error. restart fast sync v5.2.0-beta.3 HOT 6
- Add one extra layer to hide slatepack addresses.
- Foreign api get_blocks doesn’t return genesis block
- building Grin openbsd HOT 1
- Add chain type parameter into get_status rpc
- Compiling error Linux error[E0310]: the parameter type `T` may not live long enough HOT 2
- When run_tui is set to false it does not return to the cmd line once started HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from grin.