Comments (3)
I think this error is coming up from CsQuery here - and it makes sense, you've asked the selector to handle something it can't handle (irrespective of it's validity).
However, I don't think we should fall on our ass because of that, I was thinking of the following:
- We search the CSS for any unsupported selectors.
- We strip them out.
- We leave a HTML comment in the document to let the user know this has happened? (I personally hate the silent actions that just leave you clueless as to what's happened)
- Carry on processing everything else as normal.
I'll put together a pull request shortly.
from premailer.net.
I agree, never fail except for situations where an ArgumentException is suitable.
The comments in the HTML is fine for now, but I'd like to move to a concept of a more detailed result object that could look like this:
{
Output: "premailed output",
Warnings: [],
Errors: []
}
The same goes for the parameters when calling the premailer method, as more information such as base URL is needed to fix #8 and #5.
Along with the option to remove style blocks, ignore selectors, base URL etc. it might be more clean to have a class for this.
from premailer.net.
Hey @martinnormark - sounds good on the return type for MoveCssInline
. I've created #27 so it's on our radar. This will be no problem to add.
from premailer.net.
Related Issues (20)
- MoveCssInline returns self-closing title when empty HOT 5
- MoveCssInline encodes non-ASCII characters even when they should be valid HTML
- Regex in CssParser never ends and uses 100% cpu. HOT 1
- url embedded resources HOT 2
- Request to change colors defined with hsl/hsla to rgb/rgba HOT 1
- Anchor tags should be appended after analytics tags
- Performance issue when process email containing useless big Style tag to small body content HOT 1
- MoveCssInline is HTML encoding CSS HOT 2
- Inliner strips out vml from html tag HOT 1
- Configure continuous benchmark
- Add more example HTML emails to benchmark
- Automate contributors list in README
- Resolve css var's with their actual values?
- Ability to specify which classes should not be removed, like "preheader"
- How to keep html entities (such as ©) from being converted to special characters? HOT 3
- Are you looking for maintainers? HOT 23
- RobiniaDocs API Explorer
- Bug in comment regex, fix in issue description HOT 1
- Two same CSS properties on same dom element does not work HOT 3
- Bump the AngleSharp Version to 1.1.0 HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from premailer.net.