Bug: browser condition block in exports is missing default about packemon HOT 6 CLOSED

@wespickett This is true for:

[
	{
		"format": "esm"
	},
	{
		"format": "lib"
	}
]

But not:

{
	"format": ["esm", "lib"]
}

But regardless, exports are deep-merged from all artifacts.

from packemon.

@milesj

https://github.com/wespickett/packemon-test1

Steps:
npm install
cd packages/example1
npm run build

Expected:

  "exports": {
    "./package.json": "./package.json",
    ".": {
      "browser": {
        "types": "./esm/index.d.ts",
        "module": "./esm/index.js",
        "import": "./esm/index.js",
        "default": "./lib/index.js" <==== This is missing
      },
      "node": {
        "types": "./lib/index.d.ts",
        "default": "./lib/index.js"
      },
      "default": "./lib/index.js"
    }
  }

Actual:

  "exports": {
    "./package.json": "./package.json",
    ".": {
      "browser": {
        "types": "./esm/index.d.ts",
        "module": "./esm/index.js",
        "import": "./esm/index.js"
      },
      "node": {
        "types": "./lib/index.d.ts",
        "default": "./lib/index.js"
      },
      "default": "./lib/index.js"
    }
  }

from packemon.

@wespickett That's unfortunately correct... lib is configured for node, and shouldn't appear under browser.

Are you actually having issues with this? browser is used by bundlers, nothing else, and would either use require/import anyways.

from packemon.

@milesj yes, the issue is happening with jest, since we have 'browser' in the conditions list in the config. The previously published version of the packages (using packemon 2.x) do have the exports[path].browser.default key setup correctly, so this appears to be a regression

from packemon.

@wespickett v2 was actually wrong IMO.

Is browser really required in Jest? Browser is almost always ESM code, which isn't compatible with Jest. I always configure Jest to use node/cjs.

from packemon.

Removed the browser condition, and also changed the packemon configs to be ["esm", "lib"] for the browser platforms so the cjs code is generated for the defaults

from packemon.