Code Monkey home page Code Monkey logo

Comments (12)

mikhael28 avatar mikhael28 commented on August 28, 2024 1

@shubhankarb180 that sounds good, I'm assigning this ticket to you!

from paretos.

shubhankarb180 avatar shubhankarb180 commented on August 28, 2024

We could create it as a modal where we center the error container with grey blurred background. It would better implementation.

from paretos.

mikhael28 avatar mikhael28 commented on August 28, 2024

@shubhankarb180 that sounds great to me. If you can work on this, can you find a way to re-purpose the Modal.js component in src/components? Perhaps we can use it for both the terms of service and this, and we pass in some functions as props, so that it can be used in multiple use cases. Let me know if that makes sense?

from paretos.

shubhankarb180 avatar shubhankarb180 commented on August 28, 2024

Give me sometime . I need to review the code and flow to see how modal.js is being used. Once I figure that out will comment if we can re-purpose it. Sounds good ? Also can you please tell me where exactly modal.js is being used . So that I check it out once for use case purpose ??

from paretos.

mikhael28 avatar mikhael28 commented on August 28, 2024

The modal.js is being used in the Terms of Service component! You can always do global search command + shift + f and search for components/Modal to understand where that component is being imported from. Let me know if you have any other questions!

from paretos.

shubhankarb180 avatar shubhankarb180 commented on August 28, 2024

@mikhael28 , just got super busy with work. Will work on this issue on weekend. Sounds good ?

from paretos.

shubhankarb180 avatar shubhankarb180 commented on August 28, 2024

@mikhael28 Can you please reassign the issue to someone else ? I tried to work on it but not successful. Will try to work on other issues

from paretos.

mikhael28 avatar mikhael28 commented on August 28, 2024

Okay, that sounds good! Any idea what you want to start with?

from paretos.

shubhankarb180 avatar shubhankarb180 commented on August 28, 2024

I am currently looking at the queue and seeing if anything is pending that I can get started with. Let me check and will surely comment on that. In the mean time, if you find anything you want to assign , please let me know . I actually have been busy with work as I had work on weekend as well so will try and look in the issues queue now

from paretos.

mikhael28 avatar mikhael28 commented on August 28, 2024

Perhaps @shubhankarb180 you can help us with localization/internationalization - do you speak any languages fluently apart from English? We have @CoDigo93 working on Brazilian/Portugese right now, as per this ticket: #63

from paretos.

shubhankarb180 avatar shubhankarb180 commented on August 28, 2024

I speak only english as of now. Have planned to learn one more language but later šŸ˜Š. But will find one issue to work on .

from paretos.

mikhael28 avatar mikhael28 commented on August 28, 2024

@jayeclark Iā€™m going to close this issue, as you have addressed a part of the issue with your previous PR. The ultimate goal, is to replace the react-toastify package (which currently takes up 50kb of space in the application bundle) with a piece of functionality in MUI/elsewhere. For now though, Iā€™m closing :)

from paretos.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    šŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. šŸ“ŠšŸ“ˆšŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ā¤ļø Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.