Incorrect zoom coordinates when calling setZoom()/setZoomAnimated() about touchimageview HOT 10 CLOSED

It looks like that it's related to #329

To be honest, it's a community project and I'm happy to merge any pull request

from touchimageview.

This change might have caused the problem.

from touchimageview.

This change and #329 are the same 😁

But how to proceed ? I've no clue. @SimFG do you have an idea ?

from touchimageview.

You can use an image like the one below to test it. When I call setZoom(3f, 0.75f, 0.75f) I'd expect the focus to be on C7, and right now it's not there. Before the change it was working fine.

from touchimageview.

from touchimageview.

PR #509 doesn't fix the issue, but it helps hopefully later to find a solution with a test for zoom behavior.
At the bottom of the job you'll find Touch-Screenshots and here you'll find

This is the current situation. And at least it's a baseground

from touchimageview.

I think that the changes made in #329 should be reverted because the formula is incorrect. Isn't the situation described in #329 (comment) a feature and not a bug? If we focus on point 0,0, don't we expect the image to be moved down like that? If not, shouldn't we adjust getFixTrans() instead of setZoom()? I started working on it a bit, but I'm going on vacation tomorrow and won't have access to my computer for a week.

from touchimageview.

BTW, using Paparazzi for screenshot tests would be nice.

from touchimageview.

I started working on it a bit, but I'm going on vacation tomorrow and won't have access to my computer for a week.

I would love to see some outcome in the future !

from touchimageview.

closed with #514

from touchimageview.