Code Monkey home page Code Monkey logo

Comments (4)

mikeflynn avatar mikeflynn commented on July 25, 2024 1

Change merged in and README updated about the 1.7 requirement.

It's been a ridiculously crazy few weeks so thank you for the heads up and patch as I totally missed this!

from go-alexa.

mikeflynn avatar mikeflynn commented on July 25, 2024

Ugh. Compiles fine, but craps the bed in practice.

Looking at your pull request and it looks great and it's really a pretty small change, but I'm also unsure how to handle people using pre-1.7.

I guess we can merge in and then put a notice that you need 1.7 as of today.

from go-alexa.

georgevanburgh avatar georgevanburgh commented on July 25, 2024

The only semi-graceful alternative I can think of would be to abstract out
the context logic, and have two separate implementations - one for pre-1.7
(using gorilla context), and one for post (using native context), with a
conditional build tag choosing which version to include at compile time. I
guess it depends how important supporting pre-1.7 clients is to you

On 3 Oct 2016 22:11, "Mike Flynn" [email protected] wrote:

Ugh. Compiles fine, but craps the bed in practice.

Looking at your pull request and it looks great and it's really a pretty
small change, but I'm also unsure how to handle people using pre-1.7.

I guess we can merge in and then put a notice that you need 1.7 as of
today.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#7 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABl8IFon2zn_G7G0Zq0WbTDk0NwkWoLuks5qwW-IgaJpZM4KLjbN
.

from go-alexa.

mikeflynn avatar mikeflynn commented on July 25, 2024

Because of Go's no-breaking changes policy, 1.7 should be a simple upgrade for anyone. I don't think it's terrible to "require" (obviously you can't really require it with the way go get works) 1.7.

I'll merge and add a note to the README.

from go-alexa.

Related Issues (12)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.