AUTH - user confirmation about gossip HOT 8 CLOSED

Since 99% of this is done, let's close this and I'll open an issue for 'C' separately.

from gossip.

Branch for this work is 'auth'. WARNING: It will upgrade your LMDB in a way that makes it unusable back on unstable/master. Make a copy of your LMDB first in case you need to roll back.

Here is the work that is finished, and the work that is still needed:

• Augment Relay record to remember if a relay is approved or denied for both connection and authentication b193445
• Migrate to that new record b193445
• When AUTH request comes in, honor the relay setting. If the relay setting is still None, store data in GLOBALS to signal the UI that the User needs to be asked, and provide ToOverlord message handlers to handle the user action by both storing the answer and signalling the relay to either AUTH or not. a0ef26d
• When a connection to a new relay happens, honor the connection setting. If the connection setting is still None, store data in GLOBALS to signal the UI that the user needs to be asked, and provide ToOverlord message handlers to handle the user action by storing the answer and either starting the minion or not f0aad07
• Settings for both connection and auth, off by default, turning them on engages the new logic and requires per-relay approvals
• Relay pages in UI to offer switches for these two new settings
• UI to interact with the user to handle pending approvals - there may be many at once.

from gossip.

This issue is ready for UI work now.

from gossip.

Final design after discussions on TM:

from gossip.

Notes about different and less intrusive approaches that can be evaluated for the future:

• We can move the modal content to a standard view and show a new menu item, that display an alert dot when there are new elements to review;

• We can show the permission request at the thread level (e.g., with an icon) so that the user knows that in order to view all the notes, he has to approve other relays;

from gossip.

@dtonon Mike has merged the branch into unstable. Can you review and see if what we have is good for a 0.10 release?

from gossip.

@bu5hm4nn it works well!
Some details:

• A - In dark mode the Decline button should also have the Primary style (white)
• B - Would be nice if the scrolling was "external" to the modal padding, so on the extreme right
• C - The buttons on the backuground are still active to hover/press, even if the action is not triggered
• D - If possibile would be nice to lengthen the line going down a little bit
• E - The light box background should be darker, both on dark and light theme - Already fixed and pushed
• F - Keep the alignment
• G - Trim the final slash

I would also remove the "wss://" to improve readability, but I suppose protocol is an important element in the approval evaluation, right @mikedilger?
Since encrypted protocol should be the standard, maybe in the future we can globally introduce a new way to visualize the protocol, adding a warning icon near the relays that are ws://. I will open an issue to track this idea.

from gossip.

All are fixed on unstable, except for 'C'. That one is an egui bug I cannot easily fix. However once we use our own widgets, we can avoid doing the click ui action when disabled.

from gossip.