Code Monkey home page Code Monkey logo

Comments (3)

mike-kfed avatar mike-kfed commented on May 26, 2024

which version of the plugin are you using? On roundcube v1.6.0 and thunderbird_labels v1.4.12 I don't have additional vertical space used in "thunderbird style".

However I'll accept a pull-request that avoids the creation of those spans - if you really need to keep your old roundcube and old theme, because please note as of roundcube 1.6.0 "Larry and Classic are no longer part of the release packages" see their release notes.

from roundcube-thunderbird_labels.

moisseev avatar moisseev commented on May 26, 2024

Sorry, I didn't mention the version numbers. I have this issue with thunderbird_labels v1.4.12 on roundcube v1.5.3.

If the current plugin version is not supposed to be compatible with earlier roundcube versions then it's fine. It just would be nice if you mentioned requirements in the release notes.

FYI As I understand roundcube 1.6.0 release notes, Larry and Classic are not deprecated, just not included in packages anymore.

from roundcube-thunderbird_labels.

mike-kfed avatar mike-kfed commented on May 26, 2024

The plugin is compatible, because it works for you - no need to mention anything in the release notes. You have an aesthetic problem with a certain configuration. You can go ahead and fix that, likely just a CSS based workaround needed I guess?

What I wanted to say with the roundcube 1.6.0 release is, that it's more effort to install the other skins, skins that I don't use and others probably don't either since "elastic" has been out for a long time and is the default skin. Since this is just a side project for me, and not technically broken (e.g. labels not shown at all) I wont invest time into fixing this particular issue. I'll leave it open, maybe somebody has the time to look into it, as I said I'll accept a PR for it.

from roundcube-thunderbird_labels.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.