Proposal of new Fork/Reporisory/Name about gb-native-router HOT 15 OPEN

I totally agree with that.

I suggest : react-native-simple-router to clearly see the advantage compared to other.
But I like react-native-universal-router too if we can support Android.

As you expect, i'm volunteer to be a maintainer/collaborator.

For the coding styles, I recommand the following guides :

• https://github.com/airbnb/javascript
• https://github.com/airbnb/javascript/tree/master/react

Perhaps we should discuss improvements when the new repo will be created. On my side in a few days I will have to integrate this module on Android.

from gb-native-router.

I think this is more about getting a community organized repository up and running, other plans should be discussed later. react-native-simple-router is a good naming candidate IMO, although universal would also be fine.

We should liberally make people collaborators to avoid the situation we've had twice in a row now.

Also please make sure to properly attribute the two previous authors for the great work they've done!

from gb-native-router.

Vote for name:
react-native-simple-router
or
react-native-universal-router

Note that android support is already partially baked in, but simply not
implemented at a view/template level! Should be easy (mark my words.. hehe)

On Wed, Jan 20, 2016 at 3:42 PM Johann Hofmann [email protected]
wrote:

I think this is more about getting a community organized repository up and
running, other plans should be discussed later. react-native-simple-router
is a good naming candidate IMO, although universal would also be fine.

We should liberally make people collaborators to avoid the situation we've
had twice in a row now.

Also please make sure to properly attribute the two previous authors for
the great work they've done!

—
Reply to this email directly or view it on GitHub
#58 (comment)
.

from gb-native-router.

Hi there.

I'm also agree. This is a good module for React Native, but it'd be better if it'd be more active.

I'll collaborate too, as far as my knowledge reaches.

:)

from gb-native-router.

react-native-simple-router has my vote.

from gb-native-router.

👍

from gb-native-router.

https://github.com/react-native-simple-router/react-native-simple-router has been created, people participating in this conversation have been invited as organization members.

Should we fork or create a clone?

from gb-native-router.

I'd prefer clone, forks are 2nd class citizens on GitHub unfortunately. We should also make sure to get all pull requests and issues/suggestions that have been done on the other repos and backport them to the new one (that's probably gonna be hard)

from gb-native-router.

I agree with @johannhof.

from gb-native-router.

@SEthX We can start working on it if you give our team admin permissions to the repo :)

from gb-native-router.

I think i did that. did i miss something?

from gb-native-router.

It works!

from gb-native-router.

https://github.com/react-native-simple-router-community/react-native-simple-router

I've renamed the organisation, seems more fitting.

from gb-native-router.

Great!

from gb-native-router.

Glad to see simple router! Weird I didn't get a notification when tagged. If you need a contributor, prior to this module, I have been hacking at some others and got a good idea how people build the routers.

from gb-native-router.