Target port in `CONNECT` method should be figured out from `request-target` (not `Host` header) about httptosocks5proxy HOT 5 CLOSED

I can't tell from from the spec whether the hosts header may not contain a port when a connection is not meant for port 443. I can of course add functionality to try deduce the port from the request-target if one is not present in the hosts header.

from httptosocks5proxy.

My point is that it's guranteed that port will present in request-target, while Host is not.

Whoops, I missed the spot, because RFC 7230, section 5.4: Host says:

If the target URI includes an authority component, then a
client MUST send a field-value for Host that is identical to that
authority component, excluding any userinfo subcomponent and its "@"
delimiter (Section 2.7.1).

Probably should create an issue in websocket-sharp

But I still think, that trying to figure out port using more sources is better (because standards are not always followed).

from httptosocks5proxy.

I agree, I'll add it just in case someone comes across a similar scenario.

from httptosocks5proxy.

@DCNick3 Is this okay? I don't really have the means to test it.

from httptosocks5proxy.

Well, It works for me, other cases seem sane.
Thanks.

from httptosocks5proxy.