Optionally mark visibility of a dependency in output about dephpend HOT 4 CLOSED

On Fri, Apr 5, 2019, 19:44 Daniel Kinzler ***@***.***> wrote: It would be useful to me to be able to distinguish between dependencies of different visibility, in particular "public" dependencies (subclassing, implemented interfaces, public method signatures) and "private" dependencies (private method signatures, use in method bodies). For a large and messy code base like MediaWiki, this would allow further analysis to distinguish between that are hard to fix (public dependencies) and things that are easy to fix (private dependencies). This is a feature I so far have not seen in any static analysis tool. I'm wondering why, I can't be the only one who'd find this useful. Perhaps it's because static analysis tools are mostly used by design purists, and options to filter out some kinds of issues as "less bad" does not appeal to them?... When working with clean code, this kind of thing isn't needed. When trying to clean up an organically grown tangle of half a million lines, it would be great to have... Anyway. In addition to "private" and "public", there are a few in-between visibilities to be consider: - "constructor" (use in the constructor signature). Technically public, but constructor calls may be restricted to wiring code by convention, making it "internal" in a sense. For this to me useful, constructor usage should not be considered "public". - "protected" - may have to be treated as private or public, depending on context. - "internal" if the class or method has the @internal <https://github.com/Internal> tag - "deprecated" if the class or method has the @deprecated <https://github.com/deprecated> tag. This essentially makes this an extension of or alternative to issue #42 <#42>. In "text" output, with --visibility enabled, this flags could form a third column, perhaps using the form Foo --> Bar @Private <https://github.com/Private> FooBar --> Foo @public <https://github.com/public> FooBar --> Frob @Protected <https://github.com/Protected> @deprecated <https://github.com/deprecated> In GML (as proposed in #41 <#41>) this could trivially be represented as additional attributes on the edges. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#43>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ACEXfZUVNU9udLJGkmpcC-Ic6ueWxrxSks5vdzc4gaJpZM4cevtq> .