DeprecationWarning: 'get_engine' is deprecated about flask-migrate HOT 5 CLOSED

@emmanuelito As mentioned in my comment above, swapping the lines in the try and except blocks will remove the DeprecationWarning:

def get_engine():
    try:
        # this works with Flask-SQLAlchemy>=3
        return current_app.extensions["migrate"].db.engine
    except TypeError:
        # this works with Flask-SQLAlchemy<3 and Alchemical
        return current_app.extensions["migrate"].db.get_engine()

from flask-migrate.

This has already been addressed in the latest Flask-Migrate releases, but the problem is that the fix is in the env.py file that is in your migrations directory.

If you haven't made any changes to this file you can just take the updated version from here and drop it in place of the older one.

If you prefer a cleaner approach, then rename your migrations folder to some other name, then create a new migrations repository with flask db init after installing the latest Flask-Migrate, and then finally move all the Python scripts in the older migrations/versions directory to the one you just created.

from flask-migrate.

I don't think it is worth making any changes at this point. The get_engine() will be removed in 3.1 and the deprecation warning will not appear anymore. If this warning bothers you, feel free to edit your env.py.

from flask-migrate.

Awesome, thanks for the quick response!
Couple of minor improvements possible in env.py:

1. add docstrings to get_engine() and get_engine_url()
2. get_engine() has the older version in the try block and the new version in the except block, while it is the opposite in get_engine_url(). I think we can consistently use the latter order.

Thanks again.

from flask-migrate.

Thanks !
I think that the approach

def get_engine():
    try:
        # this works with Flask-SQLAlchemy<3 and Alchemical
        return current_app.extensions["migrate"].db.get_engine()
    except TypeError:
        # this works with Flask-SQLAlchemy>=3
        return current_app.extensions["migrate"].db.engine

does not eliminate the DeprecationWarning.

Because currently get_engine is ok but raise the warning.

Maybe better to check flask_sqlalchemy.__version__[0] ?

from flask-migrate.