Code Monkey home page Code Monkey logo

Comments (7)

midknight41 avatar midknight41 commented on August 28, 2024

@simranjeet2589 @phelanma You input would be appreciated.

from map-factory.

singhs020 avatar singhs020 commented on August 28, 2024

Looks good to me.

from map-factory.

midknight41 avatar midknight41 commented on August 28, 2024

@Abhisheksharma01 Any concerns from your side of things?

from map-factory.

midknight41 avatar midknight41 commented on August 28, 2024

I've fixed the remaining issue on the v1 line and will now move onto finishing the work for v2.

from map-factory.

midknight41 avatar midknight41 commented on August 28, 2024

Consider the use case of a undefined or null source field mapping to a value array.

const map = createMapper();
const src =  {
    item: null
  };

map("item").to("[]")
console.log(map.execute(src));

The current behaviour for this would return [] which still feels like the correct behaviour for v2. map.execute will always return an object of some kind but an empty object in this case feels weird. Any thoughts?

@simranjeet2589
@Abhisheksharma01

from map-factory.

midknight41 avatar midknight41 commented on August 28, 2024

Lacking any feedback I'm going with the above approach.

from map-factory.

midknight41 avatar midknight41 commented on August 28, 2024

Published as v2.0.1.

I screwed up with v2.0.0. 😭

from map-factory.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.