Comments (5)
thepercival
commented on September 21, 2024
1
Thank you also,
I learned a few things yet again!
Have a nice weekend!
I will keep testing your middlewares ;-)
Gr Coen
Op za 7 mrt. 2020 12:57 schreef Oscar Otero <[email protected]>:
… Version 2.0.1 released. Thanks for your contribution!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#6?email_source=notifications&email_token=AAM5O2CRPXSJIAXOQNKJL4TRGIZCDA5CNFSM4LCEUTF2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEODXQPA#issuecomment-596080700>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAM5O2CV7MEBVTPJ33CGIZTRGIZCDANCNFSM4LCEUTFQ>
.
from negotiation.
oscarotero
commented on September 21, 2024
Hi, thanks for bringing this up!
According to the specs (https://www.w3.org/Protocols/rfc2616/rfc2616-sec14.html):
If no Accept header field is present, then it is assumed that the client accepts all media types. If an Accept header field is present, and if the server cannot send a response which is acceptable according to the combined Accept field value, then the server SHOULD send a 406 (not acceptable) response.
So I think the good solution is returning the default type if no Accept header is found, and only return an errorResponse if no format has found but the header exists.
What do you think? Do you want to work on a pull request? It can be fixed easily here: https://github.com/middlewares/negotiation/blob/master/src/ContentType.php#L190
from negotiation.
thepercival
commented on September 21, 2024
yes, that is going to be my first pull request on an other persons project! I shall read the specs and try to make a pr.
from negotiation.
oscarotero
commented on September 21, 2024
There is always a first time for everything 😄
Thanks you!
from negotiation.
oscarotero
commented on September 21, 2024
Version 2.0.1 released. Thanks for your contribution!
from negotiation.
Related Issues (6)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from negotiation.