Code Monkey home page Code Monkey logo

Comments (8)

HenryRawas avatar HenryRawas commented on September 17, 2024

I made a fix for the communication issues.
However I was not able to get the feature to work as is. I ran into several timing issues. I tried some fixes, but still had problems. Looking in the original redis repo I see many changes to the sentinel code after 2.6.12. I think this code is not yet stable, so I will wait before coming back to this.

from redis.

jstclair avatar jstclair commented on September 17, 2024

Thanks for looking into this issue. I quickly created a copy the start_all script to run on OSX/Linux, and ran it against the latest 2.6 version (installed via brew on my mac). That seemed to work; at least, establishing the sentinel connections, and registering the available slaves.

I'll check back; in the meantime, is there some other recommendation for HA? I was chatting with some of the SignalR guys in explaining our original scenario (HA for SignalR), and they suggested looking at the Bootsleeve connection factory (which they are wrapping for the Redis backplane).

from redis.

minatl avatar minatl commented on September 17, 2024

why should call aeWinReceiveDone after redisAsyncHandleRead in redisAeReadEvent?
Isn't that redisAsyncHandleRead always call aeWinReceiveDone to add a new receive event?

from redis.

HenryRawas avatar HenryRawas commented on September 17, 2024

The aeWinReceiveDone needs to be called after reading the available data. It looks like redisAsyncHandleRead does it before reading the data.

from redis.

HenryRawas avatar HenryRawas commented on September 17, 2024

The async connect module used by sentinel has been updated to work properly in Windows. With this change the sentinel code seems to be working.

from redis.

jstclair avatar jstclair commented on September 17, 2024

Very cool, Henry. I'll check it out - first on my referenced test repository, then in our test environment.

from redis.

mike-barber-drakesoftware avatar mike-barber-drakesoftware commented on September 17, 2024

Does anyone have sentinel working correctly in windows? When I run sentinel mode it seems to connect, but it always thinks the master is down (when it's not) and when I "sentinel masters" it says that it has no other sentinels (there are 2 others) and in fact no slaves. Redis itself is running fine. My master does have a slave and that is working fine. I'm using 1.6.8-pre2 64 bit

from redis.

jepickett avatar jepickett commented on September 17, 2024

I just checked in commit ff367b5 into the 2.8.4_msopen branch that fixes the scenario mentioned in the first post of this thread. Please let me know if this works for you.

from redis.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.