Code Monkey home page Code Monkey logo

Comments (11)

stephengillie avatar stephengillie commented on August 18, 2024 2

Unfortunately, we're not able to satisfy the hardware requirement.

from winget-pkgs.

Dragon1573 avatar Dragon1573 commented on August 18, 2024 1

Really weird ...

10:42:18 D:\...\winget-pkgs  [issues/160709 +1 ~0 -0 !] 48.044s pwsh> sudo winget install -m .\manifests\a\ASRock\AppShop\2.0.0.4\
已找到 APP Shop [ASRock.AppShop] 版本 2.0.0.4
此应用程序由其所有者授权给你。
Microsoft 对第三方程序包概不负责,也不向第三方程序包授予任何许可证。
正在下载 https://download.asrock.com/Utility/Others/APPShop(v2.0.0.4).zip
  ██████████████████████████████  4.26 MB / 4.26 MB
已成功验证安装程序哈希
正在提取存档...
已成功提取存档
正在启动程序包安装...
已成功安装

image image

from winget-pkgs.

Dragon1573 avatar Dragon1573 commented on August 18, 2024 1

Do you have any other devices with non-ASRock baseboard? Could you please check if this baseboard is required for running ASRock.AppShop?

image

Note

My device is a laptop bought from HUAWEI. Some packages (such as Huawei.AppGallery and Huawei.HuaweiMobileCloud) are integrated to the initial OS image and support features only available for HUAWEI hardware.

In your situation, it would be better integrate to the OS image than asking users to install themselves. Or, provide the official link directly to users instead of asking users to search themselves.

from winget-pkgs.

Dragon1573 avatar Dragon1573 commented on August 18, 2024 1

Currently, the PR mentioned above pass the automatic validation. Moderators of this repository will perform manual validation with this package on Azure VMs.

Currently no responses from them. Patience are needed.

from winget-pkgs.

Dragon1573 avatar Dragon1573 commented on August 18, 2024 1

@RokeJulianLockhart, the hardware requirements is proved. I think we can closed this issue as "not planned".

from winget-pkgs.

RokeJulianLockhart avatar RokeJulianLockhart commented on August 18, 2024

#160709 (comment)

@Dragon1573, are you using an ASRock motherboard? I've not had that error, but I am using one:

  1. image

  2. image

from winget-pkgs.

Dragon1573 avatar Dragon1573 commented on August 18, 2024

@Dragon1573, are you using an ASRock motherboard?

Nope ... None of my device use this motherboard.

Is ASRock motherboard required? If it is, the issue should be closed as not planned because it will never pass the validation pipelines hosted on Microsoft Azure.

Issue should be marked with Blocking-Issue Manifest validation is blocked by a known issue. and Hardware Specific hardware is required to install or validate this package .

from winget-pkgs.

RokeJulianLockhart avatar RokeJulianLockhart commented on August 18, 2024

#160709 (comment)

@Dragon1573, I don't know whether it does necessitate that - it was an estimate. However, this is a quite important vendor firmware updater, so it should probably be considered based upon the fact that the motherboard itself prompts the user to install it the moment that Windows is first configured - it solely being available from their website is going to cause people to accidentally install malware from similar websites higher in Google's search rankings.

from winget-pkgs.

RokeJulianLockhart avatar RokeJulianLockhart commented on August 18, 2024

#160709 (comment)

@Dragon1573, I think you quite severely underestimate what would be bureaucratically necessary to integrate this into Windows, and why that would be wholly undesirable - generally the more modular an OS, the better. Irrespective, that shan't occur.

I do have another device with the exact same baseboard, and it indeed installs, but why do you ask - what does that demonstrate?

from winget-pkgs.

Dragon1573 avatar Dragon1573 commented on August 18, 2024

Could you launch App Shop on that non-ASRock baseboard?

I do able to submit a manifest for this package, but I think it will mostly fail during validation.


@stephengillie , this package seems hard depends on a specific hardware (baseboard), how can we dig deeper? 🙏

image
image

I created a manifest and validated with Tools/SandboxTest.ps1, it can be successfully installed but unable to launch. Should we reject this package?

from winget-pkgs.

RokeJulianLockhart avatar RokeJulianLockhart commented on August 18, 2024

#160709 (comment)

@Dragon1573, I've no non-ASRock baseboard to evaluate this on. Is there no way to perform manual validation? I ask because I've recently seen myriad reports of users falling for phishing URIs when attempting to download the installer for this package (it's a fault of ASRock's hideous SEO and bad website design) so having it on WinGet would make it easier for me to recommend it.

from winget-pkgs.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.