Code Monkey home page Code Monkey logo

Comments (4)

mdanish-kh avatar mdanish-kh commented on June 5, 2024 2

I believe this depends on:

from winget-pkgs.

github-actions avatar github-actions commented on June 5, 2024 1

Hi I'm an AI powered bot that finds similar issues based off the issue title.

Please view the issues below to see if they solve your problem, and if the issue describes your problem please consider closing this one and thumbs upping the other issue to help us prioritize it. Thank you!

Closed similar issues:

Note: You can give me feedback by thumbs upping or thumbs downing this comment.

from winget-pkgs.

BiosPlus avatar BiosPlus commented on June 5, 2024

I believe the other problem (and why I didn't include ffmpeg as a dependency in my yt-dlp PRs) is that ffmepg isn't required for the operation of yt-dl, it's needed when remuxing or converting audio/video tracks, in which case the program informs the user that ffmpeg is needed.

Would it not be best left to user choice on their installation method of this optional tool, especially given a user may already have ffmpeg available in path via an alternative means (choco for example places it in a directory within C:\programdata\choco\bin\ or something close to that effect iirc) and our dependency throws another instance of it onto a PC?

If it makes sense, I think we just keep ffmpeg out of the yt-dlp installer.yamls as a dependency.


Also, yt-dl also recommends having PhantomJS installed in some instances, yet we don't throw that in by default 😅

image

from winget-pkgs.

stephengillie avatar stephengillie commented on June 5, 2024

I believe the other problem (and why I didn't include ffmpeg as a dependency in my yt-dlp PRs) is that ffmepg isn't required for the operation of yt-dl, it's needed when remuxing or converting audio/video tracks, in which case the program informs the user that ffmpeg is needed.

If some form of FFmpeg isn't present, then I believe yt-dlp throws an error.

Would it not be best left to user choice on their installation method of this optional tool, especially given a user may already have ffmpeg available in path via an alternative means (choco for example places it in a directory within C:\programdata\choco\bin\ or something close to that effect iirc) and our dependency throws another instance of it onto a PC?

This is the goal behind the Issue that mdanish-kh linked.

If it makes sense, I think we just keep ffmpeg out of the yt-dlp installer.yamls as a dependency.

The error I mentioned above might block pipeline validation approval, or result in a poor user experience for users who don't have FFmpeg installed and don't know about it - they install a new application, get an error, and think poorly of our package manager system for allowing errant packages.

Also, yt-dl also recommends having PhantomJS installed in some instances, yet we don't throw that in by default 😅

Maybe we should. It's not in the repo yet, but appears to be a portable type of package.

from winget-pkgs.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.