Bug: "maximum display length" setting is not taking effect about vsts-extension-multivalue-control HOT 5 CLOSED

Hello everyone, we appreciate your contributions to the community. The issues have been resolved.

from vsts-extension-multivalue-control.

We are also experiencing this issue. It used to work, and now it does not. The custom value we have entered on the control extension is 75. I attempted to correct this issue by clearing out the value and saving (thus reverting to the default 35 character limit), and then going back into the control extension and setting the value back to 75 and then saving. This made no difference.

The display is showing 30 characters, plus the periods (i.e. ...), so not even the 35 which is supposed to be the default value.

I have confirmed this issue is affecting our multivalue controls in two separate Azure DevOps processes (both within the same organization).

from vsts-extension-multivalue-control.

@AminTi my colleague @AlbertArulPrakash found below:

The error seems to be in the file \src\MultiValueControl.tsx
Line 109: label={this._wrapText(o.length > 30 ? ${o.slice(0, 30)}... : o)}

this line should use the property named _labelDisplayLength which can be configured (default value 35).

from vsts-extension-multivalue-control.

I think Line 109 should probably just be: label={this._wrapText(o)}
because the _wrapText function handles adding the ellipsis if the length of the label text is greater than the _labelDisplayLength property.

private _wrapText(text: string){
    return text.length > this._labelDisplayLength ? `${text.slice(0,this._labelDisplayLength)}...` : text;
} 

from vsts-extension-multivalue-control.

I think Line 109 should probably just be: label={this._wrapText(o)} because the _wrapText function handles adding the ellipsis if the length of the label text is greater than the _labelDisplayLength property.

private _wrapText(text: string){
    return text.length > this._labelDisplayLength ? `${text.slice(0,this._labelDisplayLength)}...` : text;
} 

using _labelDisplayLength can be configured (using config files located in config folder. By default it is 35 characters.
Line 34 in same file has the initiator of _labelDisplayLength:
private readonly _labelDisplayLength: number = VSS.getConfiguration().witInputs.LabelDisplayLength ? VSS.getConfiguration().witInputs.LabelDisplayLength : 35;

The azure-devops-extension.json contains the info about this.

from vsts-extension-multivalue-control.