Code Monkey home page Code Monkey logo

Comments (4)

mjbvz avatar mjbvz commented on June 13, 2024 1

Here's a quick print out of progressive rendering timing:

Image

Notice how the current rendered text gets disposed of more than 50ms before the next text is rendered

We likely want to render the new text and then call dispose instead

from vscode.

mjbvz avatar mjbvz commented on June 13, 2024

This seems to be because the rendered markdown result is disposed of during progressive rendering, which disposes of the link handler

Been debugging but not sure why this happens while the markdown is still visible

from vscode.

roblourens avatar roblourens commented on June 13, 2024

Probably same as #195949

I haven't looked into it in awhile but always suspected it's what you say- somehow related to the gap between disposing and rendering again. But, what should happen is everything gets disposed here

then immediately rerendered. Where are those logs from?

from vscode.

roblourens avatar roblourens commented on June 13, 2024

Just doing the render shouldn't take that long, but we could create a new DisposableStore each time, and wait to dispose the previous one until after the render.

from vscode.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.