Workspace file - Can not delete in empty document about vscode HOT 7 CLOSED

@sandy081 Cn you stay the owner of the issue? If my change fixed it, good, but if not and is reopened, it's better if you investigate.

from vscode.

@vaclavHala I do not find the test file in the workspace.

from vscode.

@sandy081 did you check out the branch workspace-file-without-settings? The command in the repro steps should do that for you but maybe your git does not understand the -b flag

The package.json is supposed to run test-vscode-bootstrap.js which will launch the fakeTest.js and main file extension.js. The workspace file is also present.

I tried running the repro steps in fresh folder now and it runs the test as expected for me. Please show what error you are getting

from vscode.

@aeschli Exception is thrown here

Trying to delete a non existing property in an empty document. Should this return no edits instead of throwing error?

from vscode.

I guess we can. I created #210025.

Note there are still exceptions thrown if the operation is invalid, e.g. adding a property to a non-object.
You should still handle these...

from vscode.

That's right and I believe, I am handling those.

from vscode.

Fixed by #210025.

from vscode.