Grammar Injection doesn't not work on multi-line content about vscode-textmate HOT 8 CLOSED

Okay. Writing a TextMate Grammar: Some Lessons Learned gives a fairly good explanation about "begin..end" and "begin...while".

I am wondering is there a plan for vscode-textmate to support "begin...while"?

from vscode-textmate.

I believe we currently only support injecting into a begin end rule. This grammar ends up getting injected into a begin while instead (meta.paragraph.markdown) and ends up not being applied after the first line

from vscode-textmate.

@mjbvz thanks. But would you explain a little bit more about it. What is a "begin...while". TextMate's documentation language_grammars talks about "begin ... end", but it says nothing about "begin...while". What's the difference? Some document for "begin...while" would be perfect for me.

Additionally, can I take your comment for that vscode currently doesn't support multi-line grammar injection?

from vscode-textmate.

Well, I've figured out another way to fullfill my need, which is using a markdown-it plugin, according to the api-markdown document.

@mjbvz I think this issue can be closed. Thanks very much.

from vscode-textmate.

Related: #41

from vscode-textmate.

@zh4ui AFAIK we support "begin...while".

Closing this issue as requested.

from vscode-textmate.

@zh4ui How does markdown-it help here? Doesn't it only deal with the markdown preview?
@alexandrudima If it is not "begin...while" issue, what went wrong?

I tried

		{
			"begin": "begin",
			"end": "end",
			"name": "AAA",
			"patterns": [
				{
					"name": "BBB",
					"match": ".+"
			    }
			]
		}

The above pattern correctly recognises each line in the body as BBB

However replacing match to .*, it only recognises the first line. The rest lines are parsed as markdown instead.

from vscode-textmate.

@colinfang

Yes, markdown-it only deals with markdown preview. So I gave up trying.

I've got an impression that currently grammar injection is just a hack, rather than a useable feature.

from vscode-textmate.