Code Monkey home page Code Monkey logo

Comments (3)

AArnott avatar AArnott commented on May 22, 2024

That seems reasonable.
But I wonder: why does vscode-ws-jsonrpc use headers? Web sockets provide message boundaries in the transport, so I found that the headers were not necessary.

from vs-streamjsonrpc.

yingfangdu avatar yingfangdu commented on May 22, 2024

I think the solution is to let vs-jsonrpc to remove the headers as the header is not necessary at all.
Adding a header does not follow the jsonrpc protocol.

While for StreamJsonRPC, in order to work with other library, I think the header should be configurable.

from vs-streamjsonrpc.

AArnott avatar AArnott commented on May 22, 2024

You can do this today by exposing your WebSocket as a stream and then using the HeaderDelimitedMessageHandler class (which is used by default for streams). WebSocket doesn't offer an AsStream() extension method, unfortunately. But it's not too hard to write such a wrapper class. My team has an implementation of this that is ~150 lines.

If #80 is fixed, that may allow us to offer HeaderDelimitedMessageHandler for WebSocket as well.

from vs-streamjsonrpc.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.