Code Monkey home page Code Monkey logo

Comments (4)

jcalz avatar jcalz commented on September 27, 2024 2

Duplicate #33014

For now, if you need this behavior you either need to rewrite in terms of #47109 and use generic indexing instead of control flow anlaysis:

function func<T extends Type>(type: T, extend: X<T>) {
    const x: { [K in Type]: (type: K, x: X<K>) => void } = {
        [Type.A](type, extend) {
            console.log(type, extend);
            //                ^? (parameter) extend: string
        },
        [Type.B](type, extend) {

        }
    }
    x[type](type, extend);
}
func(Type.A, '');
func(Type.B, 1);
func(Math.random() < 0.99 ? Type.A : Type.B, 1); // still allowed, #47109 technically unsound this way

or, you need to use control flow analysis on a discriminated union and not use generics:

function func(...[type, extend]: { [T in Type]: [type: T, extend: X<T>] }[Type]) {
    if (type === Type.A) {
        console.log(type, extend);
        //                ^? (parameter) extend: string
    }
}

func(Type.A, '');
func(Type.B, 1);
func(Math.random() < 0.99 ? Type.A : Type.B, 1); // error

Playground link to code

from typescript.

MartinJohns avatar MartinJohns commented on September 27, 2024

Because checking what value type is does not have any relevance for what type the value of extend is.

This is a perfectly valid call: func<Type.A | Type.B>(Type.A, 1);

from typescript.

lengyuxuan avatar lengyuxuan commented on September 27, 2024

Because checking what value type is does not have any relevance for what type the value of extend is.

This is a perfectly valid call: func<Type.A | Type.B>(Type.A, 1);

How should I constrain the type of "extend" ? Do you have any suggestions ? Thank you so much !

from typescript.

lengyuxuan avatar lengyuxuan commented on September 27, 2024

Duplicate #33014

For now, if you need this behavior you either need to rewrite in terms of #47109 and use generic indexing instead of control flow anlaysis:

function func<T extends Type>(type: T, extend: X<T>) {
    const x: { [K in Type]: (type: K, x: X<K>) => void } = {
        [Type.A](type, extend) {
            console.log(type, extend);
            //                ^? (parameter) extend: string
        },
        [Type.B](type, extend) {

        }
    }
    x[type](type, extend);
}
func(Type.A, '');
func(Type.B, 1);
func(Math.random() < 0.99 ? Type.A : Type.B, 1); // still allowed, #47109 technically unsound this way

or, you need to use control flow analysis on a discriminated union and not use generics:

function func(...[type, extend]: { [T in Type]: [type: T, extend: X<T>] }[Type]) {
    if (type === Type.A) {
        console.log(type, extend);
        //                ^? (parameter) extend: string
    }
}

func(Type.A, '');
func(Type.B, 1);
func(Math.random() < 0.99 ? Type.A : Type.B, 1); // error

Playground link to code

Good job

from typescript.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.