Comments (6)
Specifying isolatedDeclarations: true
only makes sense if you want the errors (that's all the flag does, after all), so we should be evaluating them here. It's the same as specifying verbatimModuleSyntax
and noEmit
- the latter doesn't affect whether or not the former should do its checks
from typescript.
Debugging, handleNoEmitOptions
skips getting declaration diagnostics when noEmit
is set. The editor is different and always grabs declaration errors.
Disabling the noEmit skip there fixes the issue, but then has weird knock-on effects. I haven't been able to solve. My test has been pushed to https://github.com/jakebailey/TypeScript/tree/fix-59024 (it doesn't work in a regular compiler test since we always emit).
@sheetalkamat Do you have any ideas as to how to fix this?
from typescript.
Will take a look.
from typescript.
This is not a regression. We never reported declaration diagnostics
under --noEmit
through tsc
If we are changing this it will be need to be not a patch.
from typescript.
Not a regression, no, but I feel like we need to do something here because we're offering up these diagnostics in the editor regardless of noEmit, but then you can get a passing result at the CLI or similar which seems really, really weird?
from typescript.
These diagnostics are offered when "emitting". Eg if you ran this code with "--noCheck" you will get that error. So its just where the error gets reported. It was modeled so that we are not doing extra pass .. so dts diagnostics are always reported when emitting dts file. (only excpetion is noEmitOnError
)
from typescript.
Related Issues (20)
- Include paths evaluate to no files when tsconfig.json is in a sandbox (regression in 5.5) HOT 14
- Unpredictable behavior when trying to infer a generic type from a union function parameter HOT 1
- Generic parameter type checking stops too early HOT 9
- TS 5.5 - Imports used by decorator output are removed HOT 2
- this.constructor.staticMethod() is ok in JS, but is an error in TS HOT 1
- Incorrect transform when namespace is empty HOT 1
- Filter with a type guard fails to narrow when the type guard's predicate is a tuple supertype HOT 4
- Declaration emit change in 5.5 with `exactOptionalPropertyTypes` HOT 3
- typing for navigator.clipboard HOT 5
- Investigate Wildcard Matching Performance HOT 2
- How to correctly obtain the type of return value after the decorator HOT 1
- The type reduction of the in operator is invalid in ts 5.5 HOT 7
- `getTypeListId` crashes with `TypeError: Cannot read properties of undefined (reading 'id')`
- Suggestion: A use case requires the "nameof" operator HOT 3
- Overload call signature resolution resolves to first overload HOT 14
- FR: Add TS config option to disable "<some regex feature> is only available when targeting 'es2018' or later.". HOT 5
- Deprecating no-default-lib and rethinking of other lib related CompilerOptions HOT 1
- Function overloading of generic functions allows for invalid code HOT 1
- TS7022 (circular reference) on simple assignments in a loop HOT 6
- Suggestion xml2typescript tooling HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from typescript.