Code Monkey home page Code Monkey logo

Comments (3)

snarbies avatar snarbies commented on June 15, 2024 6

createConsoleLogger declares logger with a using declaration.

The purpose of using is to automatically call [Symbol.dispose]() when the variable goes out of scope, in this case at the end of the function, before it returns control to the caller. That means createConsoleLogger will always return a ConsoleLogger object that has an already-disposed Logger object.

The using in createConsoleLogger should be changed to var/let/const. I'd also recommend ConsoleLogger itself also implement the Disposable interface. Objects that own disposable objects should generally themselves be disposable so they can clean up any disposables they own.

If you make the ConsoleLogger class disposable then a using statement would be useful is in your main function:

using logger = createConsoleLogger();

That way your ConsoleLogger object will be disposed of at the end of main, and in turn your ConsoleLogger will dispose of the Logger that it owns.

from typescript.

RyanCavanaugh avatar RyanCavanaugh commented on June 15, 2024 1

These are the intended semantics of using. See https://github.com/tc39/proposal-explicit-resource-management

from typescript.

todor-a avatar todor-a commented on June 15, 2024

Thank you all.

from typescript.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.