Go-to-definition should only show relevant definitions when value & type have same name about typescript HOT 6 OPEN

Hi @RyanCavanaugh

Thanks for fast triaging! :-)

Wouldn't it count as a bug given value t is not the definition of type t ?

from typescript.

People complain a lot if the LS doesn't show a reference they think "should" count, but it's generally understood that a human is reading this list and can decide if the found reference is one they care about or not.

from typescript.

To be specific: the value t "could" count in the case where the code is attempting to emulate a class structure manually (i.e. type t is the class instance type, const t is the static part of the class).

from typescript.

Another example when going to definition should not show the type but it does:

https://www.typescriptlang.org/play?ts=5.5.0-dev.20240409&ssl=12&ssc=1&pln=1&pc=1#code/C4TwDgpgBMULxQN4FgBQUNQGYHscC4oA7AVwFsAjCAJwG40BfKNNAYxyIGdZYEV1MWIoQAUASngA+JA0bNUaLCSKtgASw7ZxSNJhgA6IePqpZC1EA

from typescript.

People complain a lot if the LS doesn't show a reference they think "should" count, but it's generally understood that a human is reading this list and can decide if the found reference is one they care about or not.

I see, maybe having a setting or running an experiment could help with this? It seems unfortunate that ts-server has to provide incorrect results because of some people's preferences

from typescript.

This sounds like a "cure worse than the disease" type situation.

To be specific: the value t "could" count in the case where the code is attempting to emulate a class structure manually (i.e. type t is the class instance type, const t is the static part of the class).

I couldn't even tell you the number of times I've exported both a constant and a type with the same name because they have a relationship along these lines. Factory function and instance type, interface paired with Math-like utility object, etc.

How frequent and how problematic is the issue of pulling up a type whose name is the same as an unrelated value. I'd expect it to be both rare and inconsequential.

from typescript.