Comments (5)
Narrowing can't narrow X<A | B>
to A
or B
when X
is nondistributive like NoInfer
is. You need to write NoInfer<ParametersOf<Task>> | NoInfer<GetParametersOf<Task>>
from typescript.
Aside: I'm also trying to figure out why you're using NoInfer
in the first place here.
from typescript.
Aside: I'm also trying to figure out why you're using NoInfer in the first place here.
I removed the place where I define an array of TaskCombos[]
.
const combos = [
{
task: TASK_NAMES.Task1,
parameters: { task2: true }, // This is wrong
},
] satisfies TaskCombos[]
I want to avoid TS telling me that I'm passing the wrong task
, because in this case the task
"locks" the type and parameters
should respect it (not inferring from it)
I'll close the issue, since making it NoInfer<ParametersOf<Task>> | NoInfer<GetParametersOf<Task>>
works.
from typescript.
That's also an error without using NoInfer
, though?
from typescript.
Yes, without NoInfer
the error still appears, but in more complex cases, with more parameters and more tasks, I feel that the error is better presented when using NoInfer
and also makes more sense from the developer experience sight
In my project, there are around 80 tasks, each one with its parameter type.
But some tasks parameters are very similar, which tricks (i think) TS into showing that I'm using the wrong task for that parameters in some cases.
In this case, NoInfer
makes sense to me, because I'm telling TS to avoid inferring the Task from the Parameters and only trust the task
prop
from typescript.
Related Issues (20)
- Type alias circularly references itself (5.4 regression) HOT 1
- error TS2385: Overload signatures must all be public, private or protected. HOT 2
- `export type * ...` statements in `.d.ts` files do not work (5.4 regression) HOT 4
- HTMLFormElement disallows symbol keys HOT 5
- TypeScript language service cannot find subclass references/implementation of mixin methods
- when using ts.getJSDocTags, the value of @type is not returned. Is there any solution? HOT 1
- Compiler allows narrower method signature than implemented interface HOT 6
- Allow overload signatures to have different access levels HOT 3
- Watcher recursively watches irrelevant directories HOT 11
- Auto-closing of tags within curly braces `{}` does not work when parent element is same tag in JSX HOT 1
- Undocumented breaking change in 5.5.0-beta for reference directives HOT 3
- 5.5.0 regression - importHelpers do not work with moduleResolution: bundler HOT 1
- 5.5.0 inheriting outDir: ${configDir} does not automatically exclude it from compilation HOT 3
- isolatedDeclarations wrongly enabled in VSCode HOT 3
- ESNext Set methods HOT 1
- isolatedDeclarations should not have warning for functions that have no return statements HOT 4
- Trivia ownership documentation seems to be incorrect
- `--isolatedDeclarations` allows generator functions HOT 1
- Allow `--noCheck` on the CLI with top-level `--build`
- Union in template literal simplifying unexpectedly
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from typescript.