Comments (5)
Not a bug; this behavior follows from the JS inference rules.
The implied feature request here is to issue more circularity errors.
from typescript.
It actually has nothing to do with the self-assignment; the core of the issue is that you’re initializing it to null
, which causes TS to infer any
for the type of that property (the compiler figures you probably don’t want it to stay as null
so that would be a useless inference, and evolving types for properties aren’t a thing).
Workaround: Explicitly type the property as number | null
. I’m not sure how to do that with JSDoc; maybe a @type
tag?
from typescript.
Hmm I'm not entirely sure about that, but you might be right.
For example, if you replace that line with this, the issue is also solved:
this.maybeNum = 1;
Since Math.max()
is known to always return a number
, shouldn't TypeScript be able to type the property implicitly?
For instance, this also fixes the issue:
this.maybeNum = Math.max(1);
So that seems to suggest that this is a bug after all.
I'm aware the fix is to explicitly give it a type. However, since I have TypeScript configured with noImplicitAny
, I would expect TypeScript to warn me that this property has an any
type. But now that I think about it, this is appears to be a separate issue.
from typescript.
Since
Math.max()
is known to always return anumber
, shouldn't TypeScript be able to type the property implicitly?
But you're passing this.maybeNum
in, so at that point the compiler must already know the type of maybeNum
. The compiler doesn't do type checks in two phases.
Besides that, the type number
would clearly be wrong, as you assign null
do it in the constructor. So the type would have to be number | null
.
As @fatcerberus suggested, you can do this:
/** @type {number | null} */
this.maybeNum = null;
from typescript.
The compiler doesn't do type checks in two phases.
But it doesn't need two phases though!
If you turn it into this, it also infers the type correctly:
const x = Math.max(this.maybeNum);
this.maybeNum = x;
So this is clearly a weird edge case and I'm pretty certain this is a bug :)
If not, then at least this should be considered a feature request.
from typescript.
Related Issues (20)
- TS5055: Typescript includes files in "dist" folder for compilation when `rootDir` is not `./` but `./src` even after explicitly adding "dist" to `exclude` HOT 7
- Incorrect type inference for reduce method accumulator when value is number HOT 2
- Design Meeting Notes, 4/5/2024
- type inference error HOT 3
- Function lacks ending return statement and return type does not include 'undefined' HOT 6
- Inference of recursive arrow function's return type is any HOT 2
- [NewErrors] 5.5.0-dev.20240405 vs 5.4.4 HOT 25
- [ServerErrors][TypeScript] 5.5.0-dev.20240405 HOT 17
- [ServerErrors][JavaScript] 5.5.0-dev.20240405 HOT 11
- Methods with generic properties in a class cannot be assigned to unknown. HOT 1
- Is there a good way to accurately identify the cause of an error in a union type? HOT 11
- Too wide diagnostic with array spread HOT 1
- Add persian translation to docs HOT 1
- No error when accessing setter-only properties HOT 2
- 1.88.0 update broke JS Auto Import functionality HOT 15
- "typescript.preferences.importModuleSpecifier": "project-relative" is not as intended HOT 8
- Intellisense import suggestions in JS/TS files do not work HOT 4
- Preserve `set`-only accessors in declaration emit
- NoInfer introduced in 5.4 is undocumented HOT 5
- Compile does not produce an error when parameters in overriding class method in child class have narrower type than the parameters of this method in the parent class HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from typescript.