Comments (8)
Changing to spec issue. The new compiler supports merging of all module declarations, including ambient external module declarations. I see no reason why we should only allow merging of internal modules and specifically disallow merging of ambient external modules. In particular, declaration files sometimes extend existing internal modules and may want to do exactly that for ambient external modules.
from typescript.
From design meeting: agreed this should merge just like internal modules.
from typescript.
Leaving open so we can make the text change to the spec
from typescript.
When I run this code in typescript I get
ldixon/foo.ts(4,16): error TS2000: Duplicate identifier '"fs"'. Additional locations:
ldixon/foo.ts(1,16)
ldixon/foo.ts(4,16): error TS2191: Ambient external module declaration cannot be reopened.
Sounds like the correct behaviour is no errors. Would be great to have an npm publish of a version with this fixed :)
from typescript.
agreed this should merge just like internal modules.
DT actually needs this. Thanks guys (/cc @Bartvds @vvakame will possibly make non-instantiated modules less necessary)
from typescript.
It seems like this doesn't work if the module is exported by assignment?
declare module "m" {
function inner(s: string);
module inner { export interface Test {t: string;} }
export = inner //error here
}
declare module "m" {
// even though we're only extending already existing submodule
module inner { export interface Other { t: number; } }
}
from typescript.
@spion The name inner
is not "shared" between declarations here -- when there's an export =
, all other declarations inside that module declaration are considered to not be visible at all
from typescript.
@RyanCavanaugh I see. The original problem is express.d.ts
https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/express/express.d.ts
Here, express exposes a namespace Express
to let us extend Request
. Unfortunately those extensions cannot contain types imported from ambient external modules, which means they're of limited use. However, since express-the-module is also a function, the only way to declare the module is to use declaration merging then write export = module at the end, so we can't use declaration merging for ambient external modules either.
I'll open a separate issue.
from typescript.
Related Issues (20)
- TypeScript emits incorrect type for setters in JSDoc
- Function returning `never` in branch doesn't narrow type if it's not explicitly annotated HOT 3
- Type Intersection incorrect for optional parameters in functions with `exactOptionalPropertyTypes: true`. `undefined` type is flip based off Intersection types
- Inconsistent tsc behavior on TS 5.4 HOT 2
- VSCode TypeScript extension writes tracing to the wrong directory on Mac OS HOT 1
- computed property name in an interface error when using `[]` already HOT 2
- Proposal: Type-side `instanceof` keyword and functionality HOT 8
- tsserver.js CPU/Memory Spike HOT 2
- [NewErrors] 5.5.0-dev.20240414 vs 5.4.5 HOT 26
- [ServerErrors][TypeScript] 5.5.0-dev.20240414 HOT 12
- [ServerErrors][JavaScript] 5.5.0-dev.20240414 HOT 12
- TypeScript Fails to Infer Specific Generic Types as Expected HOT 2
- [BUG]: TypeScript throws errors when adding [key: string]: string if other properties are not of type string HOT 2
- Support importing types from a `.mts` file from within a CommonJS file. HOT 7
- `(nullable?.methodOrProperty ?? defaultValue) === defaultValue` should be a type guard HOT 5
- Type refinement on properties no longer refines the whole structure HOT 3
- Import intellisense not working HOT 12
- [TypeScript] 5.4.5 - if(true) {return -1} throws off control-flow analysis HOT 1
- WebGL(2) context methods don't allow null for resource parameters HOT 2
- Interface cannot override predicate return type with boolean HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from typescript.