Comments (6)
https://github.com/Microsoft/typed-rest-client/blob/master/test/httptests.ts#L85
The key is it pipes a stream to a file (or another stream) so matter how large the file is, it will stream it chunk by chunk.
from typed-rest-client.
Closing since question answered. Let us know if you have issues.
from typed-rest-client.
Thanks @bryanmacfarlane I'll try this right away!
from typed-rest-client.
The other key is the server - hopefully it's streaming the contents but most should. Most servers don't timeout out as long as the stream is moving data.
from typed-rest-client.
NP :)
from typed-rest-client.
The example you pointed will not work. We are not awaiting for the stream write to finish.
I'll post the example and the solution, as it may help others. Check if you agree.
//
// Http get piping to another stream
// response message is an IncomingMessage which is a stream
//
cm.heading('get request and pipe stream');
let file: NodeJS.WritableStream = fs.createWriteStream(sampleFilePath);
(await httpc.get('https://httpbin.org/get')).message.pipe(file);
body = fs.readFileSync(sampleFilePath).toString();
cm.outputHttpBinResponse(body);
In this case we are not awaiting the file stream to finish. I found out that the following approach is necessary:
const file: NodeJS.WritableStream = fs.createWriteStream(filePath);
const response = await this.client.get(url);
await new Promise((resolve, reject) => {
file.on("error", reject);
file.on("finish", resolve);
response.message.pipe(file);
});
If you have a better suggestion, I'll be happy to see it.
What if we implement another method on IHttpClientResponse like saveBodyToFile?
from typed-rest-client.
Related Issues (20)
- decompressGzippedContent : missing return when rejecting promise HOT 2
- How to reuse cookie in HttpClient HOT 1
- Sending body with delete request HOT 3
- Underscore 1.12.1 being used shows vulnerability https://npmjs.com/advisories/1674
- Possible regression in proxy variable processing HOT 4
- SyntaxError: Invalid regular expression: invalid group specifier name HOT 3
- Confusing deprecation: "1.8.5 contains changes that are not compatible with Node 6" HOT 3
- Update Azure pipeline and remove GitHub action HOT 2
- Authentication header is set on redirect request HOT 1
- ETIMEDOUT for certain calls on Node 16 HOT 5
- Performance issues with readBody in HttpClient.ts HOT 3
- error from zlib not handled properly in decompressGzippedContent() HOT 4
- This repo is missing important files
- Unable to read error message from response header HOT 3
- uncaught reference error: the process does not define in browser HOT 11
- not working with react with next js , HOT 3
- Discussion: use with fetch API HOT 5
- Incorrect header check error while decompressing a response HOT 2
- Chrome 113 breaks typed-rest-client HOT 3
- Please tag released versions HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from typed-rest-client.