How to get status code from an error response? about typed-rest-client HOT 6 CLOSED

I will fix this. Thanks for the suggestion.

On a related note, there is a question whether some non error codes should even throw. Note that we also just added 3xx redirect supports so that's out of the mix.

Thoughts?

from typed-rest-client.

Looking at this now. Note the http client doesn't throw it's pure request / response in all cases. It's the higher level rest client that does the http request and turns that into a restful object. So, for example, a 404 will return an object. As noted above, we recently added 302 support.

What I'm considering:

• Only a 500 throws an exception. Even in that case, I will add the status code and body to the error object.
• 504 gateways etc... would not throw (caller may want to step off and retry)
• 3xx redirects are handled by default.
• 4xx would return response (not throw) but object / result would be null

Thoughts?

from typed-rest-client.

Bryan, this could be alreayd late to do this, but can the api be aligned to e.g. Fetch API specs in this details?
https://fetch.spec.whatwg.org/#fetch-method
https://github.github.io/fetch/ (polyfill for fetch specs)
Chrome impl for redirects: https://www.chromestatus.com/feature/4614142321229824

from typed-rest-client.

Thanks for all the feedback. We met and here's where we landed.

This ships an http and rest client.

The http client is a lower level http client. It does not throw unless something truly exceptional happened. Even a 500 successfully returns with the promise resolved.

The rest client is a higher level resource client. 200s will be resolved and 3xx redirects will be handled for you by default. In order to write linear code with the higher level client without checking after every call, the higher level rest client will throw on 4xx+ (3xx redirs handled for you).

But, to address the root concern here, I will make sure the error object has the status code and the message.

from typed-rest-client.

Fixed. Details here:

https://github.com/Microsoft/typed-rest-client#errors

and

https://github.com/Microsoft/typed-rest-client/blob/master/test/resttests.ts#L38

from typed-rest-client.

[email protected] has the fix

from typed-rest-client.