Comments (2)
Hi @a8t3r! Thanks for the reminder - I'd completely forgotten that we dont emit property-level kdoc. We did this for Java in 1.0 but demurred on Kotlin. It's been a long time since I looked at that part of the code, but IIRC I had a notion that we'd want to use @property
tags in the data class' top-level doc comment. It might be easy to do, or it might be fiddly. Certainly we could just slap the documentation on the property itself and call it a day. (if so, I think we'd need to do that here but am not positive - would need to check kotlinpoet's behavior, it might need to go on the ParameterSpec
declared above also/instead)
Agreed that we could gate that behind a compiler flag/plugin DSL function.
Honestly I won't get to this anytime soon, but I'd be thrilled to take a PR.
from thrifty.
Fixed in #524
I'll try to remember to make a point release when I come back from vacation.
from thrifty.
Related Issues (20)
- Get thrifty-runtime publishing properly
- Struct-valued constants are not yet implemented HOT 5
- Deprecated Gradle APIs in use, will break in Gradle 8 HOT 1
- Add Java codegen for struct-valued constants
- Question/feature request: Add header/comments to each file HOT 4
- This repo is missing important files
- Using thrifty-plugins with the thrifty gradle plugin HOT 9
- Add gradle-plugin API for TypeProcessor plugins
- Cyclical references in struct-valued constants? HOT 4
- Expose referenced Constants
- Schema should sort constants in dependency order
- Const refs list should be `distinct()`
- iOS support
- Gradle plugin ignores FieldNameStyle specification for Kotlin code gen HOT 1
- Fork! HOT 2
- Support iOS Simulator Arm64 Target
- [email protected] HOT 1
- BinaryProtocol hard-codes strict read/write properties
- What happened to the DecoratingProtocol? HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from thrifty.