Support for ImmutableJS reducer state about redux-dynamic-modules HOT 12 CLOSED

@navneet-g @codeocelot I'll find some time this weekend to look at this

from redux-dynamic-modules.

@navneet-g , maybe we can use the extension model like we did with sagas to add a new reducermanager that would support this behavior?

We could also add other reducer behaviors that have been requested

from redux-dynamic-modules.

I am not too familiar with ImmutableJS, could you help explain why combineReducers is incompatible with the library?

from redux-dynamic-modules.

ImmutableJS is a collection of immutable datastructures that don't support iteration over keys the same manner as vanilla js. Usually this isn't a problem for Redux as you can usually drop in a combineReducers that iterates over the keys in the immutable state correctly. To abstract this interaction in this project would probably require the ability to override the ReducerManager component.

from redux-dynamic-modules.

Sure ... you have time to take stab at that?

from redux-dynamic-modules.

@abettadapur Looking forward to immutable support over here, thanks!

from redux-dynamic-modules.

@abettadapur have you had a chance to take a look at this?

from redux-dynamic-modules.

Any progress with support for immutablejs?
Support for immutablejs is the only thing preventing us from using this library...

from redux-dynamic-modules.

Sorry for the long delay on this, and thank you for being patient!

I just put out a PR #90 which allows you to pass a custom combineReducers function. From what I see in redux-immutable, this should solve the issue

@navneet-g Could you review?

from redux-dynamic-modules.

@luskin @codeocelot Please try 5.0.0-alpha.0

Again, sorry for the delay on this

from redux-dynamic-modules.

Closing, this has been released

from redux-dynamic-modules.

Hi! I'm writing just to ask if someone have had some issues removing keys using immutable.

from redux-dynamic-modules.