Comments (4)
Hey @baywet,
To be clear, the "work" I started is really just a showcase of how the trailing slash gets eaten away when building a URL tree node.
If you'd like me to continue that work, I'm going to need some guidance as to which approach we should take.
If we find the path ends with a slash, maybe we exclude the last slash from the split, so the last segment we process has the trailing slash?
Open to suggestions here.
from openapi.net.
@mderriey Thank you for raising this and it is awesome that you have made an attempt at a PR. My first reaction to this problem is one of mild terror. You are absolutely correct that we should support this scenario. However, we need to make sure that trailing slashes do not create child nodes. We effectively want to special case this so that the trailing slash is part of the prior path segment identifier. We may need to add a new property to the tree node to indicate that it is a leaf node with a trailing slash. I'll try and spend some time to look at your PR and provide feedback.
from openapi.net.
Hi @mderriey,
Thanks for creating this issue and for starting the work for a PR.
We'll be happy to review your PR once it's ready! Make sure to add plenty of test cases!
We want to be sure extraneous nodes don't appear magically or nodes don't disappear because of that change.
from openapi.net.
@MaggieKimani1 can you help guide the contributions here please? (currently traveling for the next 10 days, it'll probably be faster this way)
from openapi.net.
Related Issues (20)
- OpenAPI 3.1 to Swagger 2.0 conversion HOT 1
- Post v2 Preview Checklist
- Use JsonSchema.NET to perform JSON schema validation
- Add wrapper type over JSON schema provided by System.Text.Json HOT 1
- Resolve `JsonSchemas` references with `$id` value pointers
- Initialization of StreamReader in OpenApiStreamReader throws an ArgumentNullException HOT 2
- OpenAPI 3.1 > Allow/Parse fields like 'description' next to #ref object properties HOT 2
- Warning 'Data and type mismatch found.' with 'date-time' format HOT 5
- hidi transform CSDL with ContainsTarget="true" infinite loop HOT 1
- Example value of an empty OpenApiArray disappears after serialization
- Error deserializing a ChatMessage HOT 1
- Typo in `IsFragrament` HOT 2
- Slack link 404
- Get operation by ID or ref
- Consider adding `Path` and `Type` properties to `OpenApiOperation` HOT 1
- Update `MapOpenApiPrimitiveTypeToSimpleType` to handle integers and numbers without a format HOT 2
- Concurrency error with reader registry
- Implement JSON schema serialization/deserialization
- Parameters defined using a `$ref` are not included in the OpenApiPathItem.Parameters collection HOT 1
- Relative reference in subdirectory OpenApi document fails to load
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from openapi.net.