Code Monkey home page Code Monkey logo

Comments (5)

weilai-irl avatar weilai-irl commented on June 13, 2024 1

Hi @joaop221

Thank you so much for making the PR. I have been planning to move all Graph API calls with pagination to a unified function that handles the skip tokens for very long time, but didn't find a good chance, until I see your PRs. I made a few more changes on top of your PR and moved all calls that have pagination that I know of to use the paginatedapicall() function that you created. There has been some changes to the function itself too to allow it to support a few more different use cases. I have tested all affected function briefly and they all work fine. I'll request a formal system test in this change before it's included in the next release.

Thank you again for your valuable contribution.

Regards,
Lai

from o365-moodle.

weilai-irl avatar weilai-irl commented on June 13, 2024 1

Hi @joaop221

We are aiming for the week of 11th of March if testing goes smoothly; otherwise it will be the week of 8th of April. I'm away for the three weeks in between.

Sorry for the delay.

Regards,
Lai

from o365-moodle.

weilai-irl avatar weilai-irl commented on June 13, 2024 1

Hi @joaop221

Changes in this issue are included in the releases from today.

Thank you very much for reporting the issue and providing the solution.

Regards,
Lai

from o365-moodle.

douglasfernandesjr avatar douglasfernandesjr commented on June 13, 2024

Great fix! In real world organizations user have a lot of groups. This gonna help me a lot

from o365-moodle.

joaop221 avatar joaop221 commented on June 13, 2024

Hi @weilai-irl.

Is there a new due date for 2024-01 milestone's features?

from o365-moodle.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.