Comments (5)
Hi @joaop221
Thank you so much for making the PR. I have been planning to move all Graph API calls with pagination to a unified function that handles the skip tokens for very long time, but didn't find a good chance, until I see your PRs. I made a few more changes on top of your PR and moved all calls that have pagination that I know of to use the paginatedapicall()
function that you created. There has been some changes to the function itself too to allow it to support a few more different use cases. I have tested all affected function briefly and they all work fine. I'll request a formal system test in this change before it's included in the next release.
Thank you again for your valuable contribution.
Regards,
Lai
from o365-moodle.
Hi @joaop221
We are aiming for the week of 11th of March if testing goes smoothly; otherwise it will be the week of 8th of April. I'm away for the three weeks in between.
Sorry for the delay.
Regards,
Lai
from o365-moodle.
Hi @joaop221
Changes in this issue are included in the releases from today.
Thank you very much for reporting the issue and providing the solution.
Regards,
Lai
from o365-moodle.
Great fix! In real world organizations user have a lot of groups. This gonna help me a lot
from o365-moodle.
Hi @weilai-irl.
Is there a new due date for 2024-01 milestone's features?
from o365-moodle.
Related Issues (20)
- Issue with Moodle course synchronization with Microsoft 365 SDS module HOT 1
- problem with Microsoft 365 Integration HOT 1
- Unit test error in MOODLE_401_STABLE HOT 3
- Moodle app tab name in teams HOT 3
- Performance issue of synchronization for a large installation HOT 1
- Moodle calendar event updates are not reflected in Teams HOT 3
- Unable to access Teams Course through LTI Moodle HOT 2
- "add entire class" greyed in LTI Moodle 4.1.9 HOT 1
- Creation of dynamic property is deprecated with PHP 8.2+ HOT 1
- We need o365-joomla plugin for Single Sign-On and Integration HOT 1
- Using guest users in EntraID - Best practices HOT 3
- Allow Mapping Username Field to Custom Attribute HOT 1
- Field mappings and synchronization working only for few fields HOT 2
- Error setting up integration "Could not get app or system token" HOT 3
- Cohort sync selector only allows selecting from the first 25 cohorts
- OIDC sid vs session_state HOT 3
- Running \local_o365\task\usersync Error HOT 2
- auth_oidc: Missing class import 'action_failed' in utils.php HOT 1
- cron behat error since updating to 2023100915
- Feature request: allow for profile photo sync on user login using user's token rather than application token HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from o365-moodle.