Code Monkey home page Code Monkey logo

Comments (6)

edwardjhu avatar edwardjhu commented on June 2, 2024

Can you share the coordinate check plots like these?

https://github.com/microsoft/mup/tree/main/examples/Transformer/coord_checks

They are really helpful for debugging.

from mup.

jiangjiadi avatar jiangjiadi commented on June 2, 2024

The coordinate check plots are given below. It seems the Mup's plot is much more stable than SP's. However, in the case of high learning rate, sometimes there will be some fluctuations in Mup's plot, and I am not sure whether these fluctuations have an impact on Mup.

  • SP, Adamw, lr=0.001
    image

  • SP, Adamw, lr=0.01
    image

  • SP, Adamw, lr=0.1
    image

  • Mup, Adamw, lr=0.001
    image

  • Mup, Adamw, lr=0.01
    image

  • Mup, Adamw, lr=0.1
    image

from mup.

edwardjhu avatar edwardjhu commented on June 2, 2024

Can you extend the x-axis to the right as much as you can for mup?

from mup.

jiangjiadi avatar jiangjiadi commented on June 2, 2024

Can you extend the x-axis to the right as much as you can for mup?

Now, I have tested the width from 48 to 3072 with the base shape = 768.

  • SP, adamw, lr=0.001
    image

  • Mup, adamw, lr=0.001
    image

from mup.

jiangjiadi avatar jiangjiadi commented on June 2, 2024

I've identified the problem. Thanks~

from mup.

Joelx avatar Joelx commented on June 2, 2024

@jiangjiadi Could you share what the problem was and how you remedied it?

from mup.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.