Code Monkey home page Code Monkey logo

Comments (3)

jplafonta avatar jplafonta commented on July 29, 2024

You are correct, this was somewhat intentional. After calling HCWebSocketConnectAsync, the internal WebSocket object will be kept alive by libHttpClient until it is disconnected - even if the client closes their handle. The handle populated in the result is guaranteed to be a valid handle to the WebSocket, while the client's handle isn't.

In theory, you should be able to disambiguate between which WebSocket is connection is completing based on the XAsync context, but I also recognize that using the returned handle would be easier/more intuitive. I will change this to pass back the client's handle as part of the connect result, but the library still makes no guarantees that the handle is valid as it's still owned by the client.

from libhttpclient.

redbaron avatar redbaron commented on July 29, 2024

In actual app context is already taken by this :) Your plan to pass handle used in connect call is very welcome. It will also make on connect callback more alike rest of callbacks on the websocket.

from libhttpclient.

jplafonta avatar jplafonta commented on July 29, 2024

Client's handle will now be returned in the async result after this change: #699

from libhttpclient.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.