MaximumOutgoingBandwidthInBytes is not respected about hcsshim HOT 7 CLOSED

@msabansal @JMesser81 PTAL

from hcsshim.

@darrenstahlmsft @msabansal @JMesser81 we've found that there might be a minimum value you have to set the MaximumOutgoingBandwidthInBytes field to around 10KB for it to be respected, is this true?

We are also having trouble verifying this feature actually works in our integration tests

from hcsshim.

@sunjayBhatia I would have to look. In RS1 days when we had our powershell containers module we had tests to validate this. When we removed the module the tests were gone and unfortunately docker didn't support specifying policies so this left a test hole. We haven't touched this code path ever though. As far as I remember we always validated in bound data rate and never the outbound rate. Does it rate limit on the inbound path properly for you?

from hcsshim.

@msabansal We have only used the QosPolicy which gives the ability to configure an outbound bandwidth. Where are we able to also configure the inbound bandwidth?

from hcsshim.

@sunjayBhatia The name is confusing. The policy can be used to rate limit inbound data and as far as I remember that was the intended use for it.

from hcsshim.

@msabansal We just figured out the cause of this issue. It turns out that QOS policies can only be applied at endpoint creation time. We were previously applying it after HotAttach with HNSEndpoint.Update. It also seems like only Outgoing traffic is affected by this property. When we tried downloading instead of uploading, the property had no affect.

This issue can now be closed.

from hcsshim.

@aminjam Thanks for confirmation. If you were applying it after update and we didn't support updating this policy we throw an error.

from hcsshim.