Assert compiling hull shader with patch constant function about directxshadercompiler HOT 3 CLOSED

Looks like it doesn't like that the constant patch function is declared after the main function. For whatever reason fxc is cool with this. I can probably update the shader to reverse the order so this isn't high priority. However, a good diagnostic describing the problem would be preferable over an assert :).

FWIW, the assert could be avoided by adding an early out return in DxilGenerationPass::CreateDxilSignatures after the line:

EntryFunc->getContext().emitError("Patch constant function is not specified.");

However, that error message is still a bit confusing.

Edit: scratch that last bit; adding an early out just causes it to crash later on.

from directxshadercompiler.

Thanks for the report - this is something we should fix to work the way fxc does.

from directxshadercompiler.

I think this is fixed by #748.

from directxshadercompiler.