Code Monkey home page Code Monkey logo

Comments (7)

sapek avatar sapek commented on June 30, 2024

As explained in the documentation the converter applies to aliases of scalars, strings and blobs. bond.GUID is a Bond defined struct.

from bond.

kylemc avatar kylemc commented on June 30, 2024

It seems pretty aggressive to close this issue so fast.

  1. It would be better if there were an explicit compile time or runtime failure. It was very difficult to track down the root cause of this failure.

  2. Why not expand support to structs? It seems like this could be considered an "enhancement" request instead of being closed outright.

from bond.

sapek avatar sapek commented on June 30, 2024

1 is a fair point but that should be a different issue with an appropriate title. BTW, alias using guid = bond.GUID is perfectly fine. What is not fine is mapping such an alias to a type (System.DateTime in your case) that is not Bond serializable (i.e. is not annotated with [Bond.Schema]). We will not support copying from one object to another (which is what BondTypeAliasConverter does) to support such mapping. If we wanted to support serializing classes/structs that are not annotated with Bond attributes we would take a different approach (user defined reflection provider) that doesn't require a copy during de/serialization.

from bond.

kylemc avatar kylemc commented on June 30, 2024

If I just change the title on this one can you repurpose it for 1 (I'm not sure if it's possible to re-open these)?

I think I follow what you're saying for 2. Feel free to put the scenario on the backlog. System.Guid is definitely the most useful representation of a Guid. My only real option with the current features is to map it to a "string", right?

from bond.

sapek avatar sapek commented on June 30, 2024

string or blob, depending if you care about small binary representation or human readable text representation.

from bond.

kylemc avatar kylemc commented on June 30, 2024

Great. Thanks.

from bond.

 avatar commented on June 30, 2024

What's the state of the issue?
I return result from the service via "Message.From(...)" and a single place where I see the exception out of the serialization is a GRPC console log.
So I get no exceptions on the server side.

from bond.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.