Remove usages of sprintf from C++ implementation about bond HOT 8 CLOSED

sprintf_s is not a standard function. std::snprintf is only available in C++11 and for example VC12 doesn't support it.

from bond.

I think even snprintf is banned by SDL. Could we conditionally upgrade to using sprintf_s if MSVC is detected? (Since it's writing into a stack-allocated buffer the code would just need to switch function calls without further changes - sprintf_s is templated for this case.)

from bond.

Potential fix: https://github.com/Porges/bond/commit/9c29ed6c7c2b041231d0cab33341903f4b457630

from bond.

I don't want to add conditional code with proprietary extensions. A better solution is to get rid of sprintf altogether. It is an overkill anyways since we only depend on it to convert integers to string.

from bond.

"Get rid of sprintf altogether" is always the better choice for simple conversions. For complex conversions, that’s what std::ostringstream is for.

from bond.

Would it be sane to just replace the custom basic_string_stream class with the std one? Then this could be avoided entirely - assuming there's not a strong reason to keep it. Does it exist for performance concerns/compatibility?

from bond.

Performance.

from bond.

OK. I guess I can just switch on _CRT_SECURE_CPP_OVERLOAD_STANDARD_NAMES anyway ☺

from bond.