Exception Handling about applicationinsights-php HOT 3 CLOSED

+1 - I am affected by this too. In my WordPress app, I just changed the method signature to take a Throwable rather than an Exception but obviously that's not a great approach. I'd be happy to provide a patch or pull request if that would help.

from applicationinsights-php.

Haha, the same, I am not a PHP developer either, but Throwable was introduced in PHP 7. What is the best approach here?

• Create a new method named something like trackThrowable which takes a Throwable?
  • Does a type annotation which refers to a type which does not exists cause an error in PHP 5?
  • This could also lead to disharmony among the implementations of the TelemetryClient in different languages.
• Omit the type annotation to accept both Exception and Error?
  • To maintain compatibility with PHP 5
  • But PHP 7 loses type safety here with this change

from applicationinsights-php.

I'd suggest implementing both as additional methods, trackThrowable and trackError.

from applicationinsights-php.