Code Monkey home page Code Monkey logo

Comments (5)

MaxShehovtsov avatar MaxShehovtsov commented on May 21, 2024

@SergeyKanzhelev I agree. However if custom property 'duration' already exists we shouldn't override it - in this case the duration of this timed event won't be sent.

from applicationinsights-js.

SergeyKanzhelev avatar SergeyKanzhelev commented on May 21, 2024

API is confusing. We either need to remove it or fix it so it sends duration. Maybe the better option will be to remove this API and make use of trackAjax instead?

from applicationinsights-js.

MaxShehovtsov avatar MaxShehovtsov commented on May 21, 2024

I think we should keep it as it's different from ajax/dependency call. Although it's more useful for 'usage' than 'diagnostics'. I'm going to stick with my proposal of setting 'duration' custom property if it's not already set, otherwise lose it.

from applicationinsights-js.

KamilSzostak avatar KamilSzostak commented on May 21, 2024

Fixed: #90

from applicationinsights-js.

github-actions avatar github-actions commented on May 21, 2024

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

from applicationinsights-js.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.