Comments (5)
I also have the issue for my web site.
For Safari in private browsing the browser hands out the window.localStorage objet but throws an exception when using the SetItem member.
The problem is in Util.ts. The _getStorageObject and _getSessionStorageObject functions return the storage object but when the write functions use the storage object it throws an exception causing the write functions to return false. This causes the caller loop.
The _getStorage*Object functions should use a pattern where they validate the storage object by performing a test write operation before handing out the object. This is a common pattern - e.g. see https://mathiasbynens.be/notes/localstorage-pattern.
from applicationinsights-js.
Hope the AI team can review the PR which should fix this issue. I can't run the unit tests locally, the PS script opens an HTML page with empty unit tests. I can test the results via Browserstack.
from applicationinsights-js.
@tsj0603 thanks for explaining that. While you were typing that out, I was making the PR, teamwork! π
from applicationinsights-js.
As confirmed in PR #146, the issue has been fixed and CDN has been updated. Again, thanks a lot for the quick fix, @AlexBulankou. π
from applicationinsights-js.
This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
from applicationinsights-js.
Related Issues (20)
- how to fix "NullInjectorError: No provider for AppInsightsSku!" HOT 2
- [BUG] Retry on sampled out telemetry is looping infinitely HOT 5
- Add `customSpan` telemetry type HOT 8
- [Question] App crash with the trace message HOT 1
- [BUG] - CRITICAL - Application runs out of memory HOT 7
- [BUG] Filtering logs with status code 308 does not work HOT 2
- Deprecated feature used when using with jQuery 3.7.1 HOT 8
- [BUG] `ITelemetryItem` uses intersection type instead of union type for `tags` property HOT 4
- [BUG] Network calls aren't visualized correctly between frontend(AI-JS) / backend(Azure Otel Distro) components in Application Map HOT 2
- [BUG] [Web-Snippet] dependency chain issues
- [BUG] Event time is not set HOT 4
- [BUG] @microsoft/applicationinsights-web-snippet version 1.1.1 type problem
- `console.log` unnecessarily noisy HOT 3
- Need to add max retry count for telemetry events to prevent events accumulation in sent buffer
- [Offline Support] offline support plugin can't be added to extensions of core config now, it can only be added through addPlugin
- [main] retry document updates HOT 1
- [BUG] remove 403 as a βretriableβ error code
- [BUG] Circular dependencies
- ApplicationInsights-JS latest version 3.1.1 giving TypeError: Cannot read properties of undefined (reading 'getCrypto') HOT 32
- [BUG] Excessive memory usage for SPA where unload hooks keep accumulating HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from applicationinsights-js.