I've noticed problem leading to memory leaks and executing of shutdown hook many times

I don't see anything like this in .Net client: <div class="highlight highlight-sou

<a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/us

SDKShutdownActivity is calling multiple times for same Channel about applicationinsights-java HOT 5 CLOSED

microsoft commented on May 21, 2024

SDKShutdownActivity is calling multiple times for same Channel

from applicationinsights-java.

Comments (5)

Dmitry-Matveev commented on May 21, 2024 1

I would recommend to go with fewer TelemetryClient instances to limit the impact. I cannot talk about why it was implemented in this particular way, we may need to involve the original code owners here.

.NET SDK usage typically involves a limited set of Telemetry Client instances, but it does not save user context in there, thus no appeal for "new"-ing up new instance every time. I would expect that Java SDK also should not save such a context per client instance.

BTW, .NET used to have a leak in Telemetry Clients and Channels as well.

from applicationinsights-java.

Mart-Bogdan commented on May 21, 2024

I don't see anything like this in .Net client:

        /// <summary>
        /// Initializes a new instance of the <see cref="TelemetryClient" /> class. Send telemetry with the specified <paramref name="configuration"/>.
        /// </summary>
        /// <exception cref="ArgumentNullException">The <paramref name="configuration"/> is null.</exception>
        /// <exception cref="ArgumentException">The <paramref name="configuration"/> does not contain a telemetry channel.</exception>
        public TelemetryClient(TelemetryConfiguration configuration)
        {
            if (configuration == null)
            {
                CoreEventSource.Log.TelemetryClientConstructorWithNoTelemetryConfiguration();
                configuration = TelemetryConfiguration.Active;
            }

            this.configuration = configuration;

            if (this.configuration.TelemetryChannel == null)
            {
                throw new ArgumentException("The specified configuration does not have a telemetry channel.", "configuration");
            }
        }