Code Monkey home page Code Monkey logo

Comments (7)

SergeyKanzhelev avatar SergeyKanzhelev commented on May 21, 2024

I believe it is an optimization. In case when iKey was not set for win store application - we will not try to access Context property of an item and will not construct it. @JakubOleksy, is it actually by design or not?

from applicationinsights-dotnet.

JakubOleksy avatar JakubOleksy commented on May 21, 2024

Correct, we need a way to quickly stop processing when iKey is not set and have minimum impact on the application.

from applicationinsights-dotnet.

abaranch avatar abaranch commented on May 21, 2024

If that is by design instrumentation key should be removed from the telemetry item.

from applicationinsights-dotnet.

SergeyKanzhelev avatar SergeyKanzhelev commented on May 21, 2024

I was thinking that since it's all internal - we can have internal method to check whether Context was initialized on telemetry item. If so - checking instrumentation key on telemetry item would be fast. If not - do not check it since it clearly wasn't set

from applicationinsights-dotnet.

JakubOleksy avatar JakubOleksy commented on May 21, 2024

We probably don't need to make it even settable at an item level. I am not sure the scenario that would require that.

from applicationinsights-dotnet.

SergeyKanzhelev avatar SergeyKanzhelev commented on May 21, 2024

Hm, I took a look and it seems that my information is outdated. Now context being instantiated in constructors of telemetry items. See ExceptionTelemetry.cs#L32 as an example. So it looks like a simple bug

from applicationinsights-dotnet.

SergeyKanzhelev avatar SergeyKanzhelev commented on May 21, 2024

@JakubOleksy , typical scenario is to split auto-collected data into different instrumentation keys to protect critical data from being throttled because of high volume non-important events. Examples are sending performance counters to a separate iKey or re-route verbose traces. We recommended this approach (telemetry initializer that overrides iKey) to somebody for exactly this reason.

from applicationinsights-dotnet.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.