Using power-assert causes Webpack builds to fail about micromark HOT 13 CLOSED

Switched to uvu/assert everywhere!

from micromark.

The reason to use power-assert was that vite and webpack were not able to use assert: #87

from micromark.

I would be happy to create a types package with type assertions for any package that you would like to use. Looks like uvu/assert declares their own types though so not sure how long it would take to get that merged.

from micromark.

Thanks!

from micromark.

Just noting our build started breaking too because of this issue.

from micromark.

how did it work before?

from micromark.

Apparently, it previously picked up the actual npm assert package, which "simply" worked. Our monorepo package.json explicitly installs this package, so it was always there.

from micromark.

I’m thinking of either reversing the change and just documenting that folks need to configure their bundlers (by installing assert, by using https://github.com/unassert-js/rollup-plugin-unassert or https://github.com/unassert-js/webpack-unassert-loader, or by configuring their bundler to polyfill assert). Or, alternatively, to create a new mini-assert and get unassert to use it.

from micromark.

Since it's just simple assertions, that would be a really short function to implement. I'd even consider inlining it.
also, from a quick search in npm (searched for "tiny assert") there's https://www.npmjs.com/package/nanoassert

from micromark.

One important addition is TypeScript, which that package doesn’t have. I was also thinking of uvu/assert, but it doesn’t have typescript assertions either,.

I'd even consider inlining it.

That prevents the assertions from being removed. micromark does not include assertions in production code. That would add assertions to production code.

from micromark.

I see. I don't think having it inline vs external package should affect the ability to disable / tree shake it in production mode. I'm not sure of micromark's current build process though, so I could be mistaken...

from micromark.

At least one assertion also does type narrowing in uvu https://github.com/lukeed/uvu/blob/d56753ec20928da1c22ff093cb07ce3c67613706/src/assert.d.ts#L4
But that and several other type fixes are unreleased, having happened after https://github.com/lukeed/uvu/releases/tag/v0.5.1

from micromark.

Hi! This was closed. Team: If this was fixed, please add phase/solved. Otherwise, please add one of the no/* labels.

from micromark.