Comments (7)
I know, but I consider the effort to remove it implies more cost than simply pass it
what do you think?
from sdk.
Yeah I had a quick go at it and gave up quickly 😅
I was thinking we could create a small util. method, where we pass props
& the keys of props we want to exclude from a return object. Eg:
const propCleaner = (obj, excludeKeys) => {
const objKeys = Object.keys(obj)
return objKeys.reduce((acc, key) => {
if (!excludeKeys.include(key)) {
acc[key] = obj[key]
}
return acc
})
}
<Component {...propCleaner(props, ['apiKey', 'autoPlay'])} />
(not ran/tested)
from sdk.
Maybe https://www.npmjs.com/package/clean-tag?activeTab=readme
from sdk.
Yep that seems to do basically what I was suggesting.
We'll have to see how the size looks with it included - https://bundlephobia.com/[email protected]
from sdk.
I would not worry unless it represents a problem
The cost of add 11kb extra size into the library vs 0kb, also not logic for handle this 🙂
from sdk.
Just came across this @Kikobeats. Lodash's omit should do the trick.
I think we should implement this as we're generating slightly unsemantic markup, passing "media" attributes (autoplay, etc) to DOM elements that shouldn't receive them.
from sdk.
agree!
from sdk.
Related Issues (20)
- microlink.io is down? HOT 1
- Separate `fetch` from `setData`
- Make embeds clickable while loading HOT 1
- [vue] Can't perform a React state update on an unmounted component HOT 1
- [hover-react] testing snapshot fails
- A better way to customize basic style
- Add a way to pass iframe options HOT 2
- Links to documentation and storybook don't work
- Storybook link down HOT 1
- Styling of card loader HOT 8
- it fails for some websites that need to accept cookies HOT 5
- Microlink Hover improvements
- Is using raw `video` urls / mp4's legal in the preview? HOT 2
- apikey being passed to the Iframe wrapper component HOT 2
- Crashed with invalid link HOT 4
- Cors on any link HOT 1
- Running React v17 won't compile - @microlink/react gives an error about needing an additional loader in (MicrolinkError) HOT 2
- Upgrade microlink react SDK Styled-Component Package HOT 1
- FYI this isn't working very well with youtube at the moment HOT 7
- Instagram links aren't fetching HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from sdk.