Unnecessary props passed to DOM about sdk HOT 7 CLOSED

I know, but I consider the effort to remove it implies more cost than simply pass it

what do you think?

from sdk.

Yeah I had a quick go at it and gave up quickly 😅

I was thinking we could create a small util. method, where we pass props & the keys of props we want to exclude from a return object. Eg:

const propCleaner = (obj, excludeKeys) => {
  const objKeys = Object.keys(obj)

  return objKeys.reduce((acc, key) => {
    if (!excludeKeys.include(key)) {
      acc[key] = obj[key]
    }
    return acc
  })
}
 
<Component {...propCleaner(props, ['apiKey', 'autoPlay'])} />

(not ran/tested)

from sdk.

Maybe https://www.npmjs.com/package/clean-tag?activeTab=readme

from sdk.

Yep that seems to do basically what I was suggesting.

We'll have to see how the size looks with it included - https://bundlephobia.com/[email protected]

from sdk.

I would not worry unless it represents a problem

The cost of add 11kb extra size into the library vs 0kb, also not logic for handle this 🙂

from sdk.

Just came across this @Kikobeats. Lodash's omit should do the trick.

I think we should implement this as we're generating slightly unsemantic markup, passing "media" attributes (autoplay, etc) to DOM elements that shouldn't receive them.

from sdk.

agree!

from sdk.