Comments (2)
I would actually classify that as a Sequelize bug.
Sequelize is supposed to do the replacement, but i guess it isn't doing it properly in this case.
from graphql-sequelize.
You're absolutely right, I hadn't tried to run the Sequelize query directly. When running the query via Sequelize 3.13.0 with ordering parameters that should be escaped:
import _ from 'underscore';
import Promise from 'bluebird';
import Sequelize from 'sequelize';
const peopleData = [
{id: 1, name: 'John'},
{id: 2, name: 'Jane'},
{id: 3, name: 'Jill'}
];
const sequelize = new Sequelize(process.env.DB);
const PersonModel = sequelize.define('Person', {
name: {type: Sequelize.STRING, field: 'fullName'}
}, {
tableName: 'LegacyPeople'
});
// exploded models drop and sync, and data insert for clarity
Promise.each(
[
PersonModel
],
(Model) => Model.drop()
).then(() => (
Promise.each(
[
{Model: PersonModel, data: peopleData},
],
(pair) => {
const {Model, data} = pair;
return Model.sync().then(() => (
Promise.each(data, (entry) => (
Model.create(entry)
))
));
}
)
)).then(
() => (PersonModel.findAll({
attributes: ['id', 'name'],
order: [
['name']
]
}))
).then((people) => {
people.forEach((person) => {console.log(person.id, person.name)});
});
it generates the SQL query without escaping:
SELECT [id], [fullName] AS [name] FROM [LegacyPeople] AS [Person] ORDER BY [Person].[name];
on MS SQL. Thank you, I'll direct this to the Sequelize project!
from graphql-sequelize.
Related Issues (20)
- Combining multiple associations HOT 5
- Problem integrating connection types and dataloader for paginated (cursor) queries HOT 1
- When using `JSONType` I get `Error: One of the provided types for building the Schema is missing a name.` HOT 2
- Can we use `attributeFields` with graphql SDL? HOT 2
- How to express two way relationship HOT 2
- Change the default name of Date scalar HOT 3
- Relay Connections with Dataloader HOT 4
- Is this working with GraphQL 15? HOT 2
- sequelize model comment => graphql field description HOT 4
- CITEXT throws an issue in the latest version HOT 7
- Unable to convert geometry to graphql type HOT 1
- Are filtering operators supported? HOT 2
- OrderBy can conflicts with Attributes HOT 1
- Passing `where:` in-place, without query variable HOT 2
- Fix order type in defaultListArgs HOT 6
- Compatibility with GraphQL v17 HOT 1
- Peer dependency support for graphql 16 HOT 2
- OrderBy doesn't pass multiple to the query HOT 1
- Changing relay edges to be nonNull causes a node error HOT 3
- Use graphql-sequelize with dataloader-sequelize HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from graphql-sequelize.