Code Monkey home page Code Monkey logo

Comments (2)

mickhansen avatar mickhansen commented on July 22, 2024

I would actually classify that as a Sequelize bug.
Sequelize is supposed to do the replacement, but i guess it isn't doing it properly in this case.

from graphql-sequelize.

moret avatar moret commented on July 22, 2024

You're absolutely right, I hadn't tried to run the Sequelize query directly. When running the query via Sequelize 3.13.0 with ordering parameters that should be escaped:

import _ from 'underscore';
import Promise from 'bluebird';
import Sequelize from 'sequelize';

const peopleData = [
  {id: 1, name: 'John'},
  {id: 2, name: 'Jane'},
  {id: 3, name: 'Jill'}
];

const sequelize = new Sequelize(process.env.DB);

const PersonModel = sequelize.define('Person', {
  name: {type: Sequelize.STRING, field: 'fullName'}
}, {
  tableName: 'LegacyPeople'
});

// exploded models drop and sync, and data insert for clarity

Promise.each(
  [
    PersonModel
  ],
  (Model) => Model.drop()
).then(() => (
  Promise.each(
    [
      {Model: PersonModel, data: peopleData},
    ],
    (pair) => {
      const {Model, data} = pair;
      return Model.sync().then(() => (
        Promise.each(data, (entry) => (
          Model.create(entry)
        ))
      ));
    }
  )
)).then(
  () => (PersonModel.findAll({
    attributes: ['id', 'name'],
    order: [
      ['name']
    ]
  }))
).then((people) => {
  people.forEach((person) => {console.log(person.id, person.name)});
});

it generates the SQL query without escaping:

SELECT [id], [fullName] AS [name] FROM [LegacyPeople] AS [Person] ORDER BY [Person].[name];

on MS SQL. Thank you, I'll direct this to the Sequelize project!

from graphql-sequelize.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.